Only schedule parallel Upload Tasks #817
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 98.02% 97.82% -0.21%
==========================================
Files 444 444
Lines 36488 36467 -21
==========================================
- Hits 35769 35674 -95
- Misses 719 793 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 98.02% 97.82% -0.21%
==========================================
Files 444 444
Lines 36488 36467 -21
==========================================
- Hits 35769 35674 -95
- Misses 719 793 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 98.02% 97.82% -0.21%
==========================================
Files 444 444
Lines 36488 36467 -21
==========================================
- Hits 35769 35674 -95
- Misses 719 793 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 98.02% 97.82% -0.21%
==========================================
Files 444 444
Lines 36488 36467 -21
==========================================
- Hits 35769 35674 -95
- Misses 719 793 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
With parallel upload processing fully rolled out, its time to start cleaning up the feature flag. This first step is changing the initial `Upload` task to only schedule the parallel version of `UploadProcessor/Finisher`. As there will probably be a bunch of already scheduled tasks at time of deploy, this does not yet change those tasks to assume they run in fully parallel mode.
Swatinem
force-pushed
the
swatinem/schedule-parallel
branch
from
0944681
to
62de8fd
Compare
| @@ -80,6 +80,7 @@ def run_impl( | |||
| commitid, | |||
| commit_yaml, | |||
| arguments_list, | |||
| arguments=None, | |||
There was a problem hiding this comment.
do you know the type of arguments or arguments_list?
There was a problem hiding this comment.
yes, I have plans to properly type those as TypedDict in the future.
With parallel upload processing fully rolled out, its time to start cleaning up the feature flag.
This first step is changing the initial
Uploadtask to only schedule the parallel version ofUploadProcessor/Finisher.As there will probably be a bunch of already scheduled tasks at time of deploy, this does not yet change those tasks to assume they run in fully parallel mode.