Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReducedError to make it more similar to Django Model #808

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

michelletran-codecov
Copy link
Contributor

In particular, this table doesn't actually have an external id.

This was pulled out from #729

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

In particular, this table doesn't actually have an external id.
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) ⬇️
unit 97.98% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) ⬇️
OutsideTasks 97.96% <85.71%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) ⬇️
unit 97.98% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) ⬇️
OutsideTasks 97.96% <85.71%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) ⬇️
unit 97.98% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) ⬇️
OutsideTasks 97.96% <85.71%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) ⬇️

Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) ⬇️
unit 97.98% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) ⬇️
OutsideTasks 97.96% <85.71%> (-0.01%) ⬇️
Files Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) ⬇️

@michelletran-codecov michelletran-codecov marked this pull request as ready for review October 22, 2024 22:19
@michelletran-codecov michelletran-codecov requested a review from a team October 22, 2024 22:20
@michelletran-codecov michelletran-codecov added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 1b94a4e Oct 23, 2024
24 of 27 checks passed
@michelletran-codecov michelletran-codecov deleted the make_reduced_error_like_django branch October 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants