Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: update shared (get_PR changed to use graphQL) (#776)" #779

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

giovanni-guidini
Copy link
Contributor

This reverts commit a4a3d79.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

This PR includes changes to shared. Please review them here: codecov/shared@6c0c2d6...b9e83b2

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (a4a3d79) to head (55c5740).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         438      438           
  Lines       36471    36470    -1     
=======================================
+ Hits        35751    35752    +1     
+ Misses        720      718    -2     
Flag Coverage Δ
integration 98.03% <100.00%> (+<0.01%) ⬆️
unit 98.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.90% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.00% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/repository.py 96.76% <100.00%> (-0.02%) ⬇️
services/tests/test_repository_service.py 99.78% <100.00%> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (a4a3d79) to head (55c5740).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         438      438           
  Lines       36471    36470    -1     
=======================================
+ Hits        35751    35752    +1     
+ Misses        720      718    -2     
Flag Coverage Δ
integration 98.03% <100.00%> (+<0.01%) ⬆️
unit 98.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.90% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.00% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/repository.py 96.76% <100.00%> (-0.02%) ⬇️
services/tests/test_repository_service.py 99.78% <100.00%> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         438      438           
  Lines       36471    36470    -1     
=======================================
+ Hits        35751    35752    +1     
+ Misses        720      718    -2     
Flag Coverage Δ
integration 98.03% <100.00%> (+<0.01%) ⬆️
unit 98.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.90% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.00% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/repository.py 96.76% <100.00%> (-0.02%) ⬇️
services/tests/test_repository_service.py 99.78% <100.00%> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (a4a3d79) to head (55c5740).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   98.02%   98.03%           
=======================================
  Files         438      438           
  Lines       36471    36470    -1     
=======================================
+ Hits        35751    35752    +1     
+ Misses        720      718    -2     
Flag Coverage Δ
integration 98.03% <100.00%> (+<0.01%) ⬆️
unit 98.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.90% <100.00%> (+0.01%) ⬆️
OutsideTasks 98.00% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
services/repository.py 96.76% <100.00%> (-0.02%) ⬇️
services/tests/test_repository_service.py 99.78% <100.00%> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 1799be9 Oct 11, 2024
26 of 27 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/revert-previous branch October 11, 2024 10:30
Copy link

sentry-io bot commented Oct 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ InternalError: (psycopg2.errors.InFailedSqlTransaction) current transaction is aborted, commands ignored until e... app.tasks.pulls.Sync View Issue
  • ‼️ OperationalError: (psycopg2.errors.DeadlockDetected) deadlock detected app.tasks.pulls.Sync View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants