Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing tags explicitly #769

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add tracing tags explicitly #769

merged 1 commit into from
Oct 8, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Oct 8, 2024

This will now add some common task tags to the Sentry transaction as well. Not sure why, but this used to just work using the global tags, but stopped working at some point (possibly because of an SDK update?)

This will now add some common task tags to the Sentry transaction as well.
Not sure why, but this used to just work using the global tags, but stopped working at some point (possibly because of an SDK update?)
@Swatinem Swatinem requested a review from a team October 8, 2024 10:06
@Swatinem Swatinem self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (be5c54f) to head (fb0ff86).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
helpers/telemetry.py 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.01%     
==========================================
  Files         438      438              
  Lines       36427    36451      +24     
==========================================
+ Hits        35703    35733      +30     
+ Misses        724      718       -6     
Flag Coverage Δ
integration 98.03% <40.00%> (+0.01%) ⬆️
unit 98.03% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <40.00%> (+0.04%) ⬆️
OutsideTasks 98.00% <40.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
helpers/telemetry.py 86.84% <40.00%> (-3.30%) ⬇️

... and 4 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (be5c54f) to head (fb0ff86).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
helpers/telemetry.py 40.00% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.01%     
==========================================
  Files         438      438              
  Lines       36427    36451      +24     
==========================================
+ Hits        35703    35733      +30     
+ Misses        724      718       -6     
Flag Coverage Δ
integration 98.03% <40.00%> (+0.01%) ⬆️
unit 98.03% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <40.00%> (+0.04%) ⬆️
OutsideTasks 98.00% <40.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
helpers/telemetry.py 86.84% <40.00%> (-3.30%) ⬇️

... and 4 files with indirect coverage changes

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
helpers/telemetry.py 40.00% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.01%     
==========================================
  Files         438      438              
  Lines       36427    36451      +24     
==========================================
+ Hits        35703    35733      +30     
+ Misses        724      718       -6     
Flag Coverage Δ
integration 98.03% <40.00%> (+0.01%) ⬆️
unit 98.03% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <40.00%> (+0.04%) ⬆️
OutsideTasks 98.00% <40.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
helpers/telemetry.py 86.84% <40.00%> (-3.30%) ⬇️

... and 4 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.03%. Comparing base (be5c54f) to head (fb0ff86).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   98.01%   98.03%   +0.01%     
==========================================
  Files         438      438              
  Lines       36427    36451      +24     
==========================================
+ Hits        35703    35733      +30     
+ Misses        724      718       -6     
Flag Coverage Δ
integration 98.03% <40.00%> (+0.01%) ⬆️
unit 98.03% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.89% <40.00%> (+0.04%) ⬆️
OutsideTasks 98.00% <40.00%> (-0.02%) ⬇️
Files Coverage Δ
helpers/telemetry.py 86.84% <40.00%> (-3.30%) ⬇️

... and 4 files with indirect coverage changes

@Swatinem Swatinem added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit e1ed10a Oct 8, 2024
19 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/transaction-tags branch October 8, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants