Gracefully upgrade existing tasks to parallel processing #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parallel upload processing feature flag had an edge-case where toggling the feature flag would effect all *already running* tasks, moving them from experiment mode to fully parallel mode. Now this decision is being made at the very beginning in `Upload`, and the scheduled tasks adhere to that decision.
giovanni-guidini
approved these changes
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 438 438
Lines 36389 36386 -3
==========================================
- Hits 35672 35669 -3
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 438 438
Lines 36389 36386 -3
==========================================
- Hits 35672 35669 -3
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 438 438
Lines 36389 36386 -3
==========================================
- Hits 35672 35669 -3
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 98.02% 98.02% -0.01%
==========================================
Files 438 438
Lines 36389 36386 -3
==========================================
- Hits 35672 35669 -3
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parallel upload processing feature flag had an edge-case where toggling the feature flag would effect all already running tasks, moving them from experiment mode to fully parallel mode.
Now this decision is being made at the very beginning in
Upload, and the scheduled tasks adhere to that decision.