Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to avoid status + checks at the same time #756

Merged
merged 3 commits into from
Oct 4, 2024

Merge branch 'main' into 1967-adjust-checks-with-fallbacks

901e799
Select commit
Loading
Failed to load commit list.
Merged

Add call to avoid status + checks at the same time #756

Merge branch 'main' into 1967-adjust-checks-with-fallbacks
901e799
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 4, 2024 in 0s

98.01% (-0.02%) compared to 47c669a

View this Pull Request on Codecov

98.01% (-0.02%) compared to 47c669a

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (47c669a) to head (901e799).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.02%     
==========================================
  Files         438      438              
  Lines       36386    36420      +34     
==========================================
+ Hits        35669    35696      +27     
- Misses        717      724       +7     
Components Coverage Δ
NonTestCode 95.85% <100.00%> (-0.05%) ⬇️
OutsideTasks 98.02% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
services/notification/notifiers/checks/base.py 97.51% <100.00%> (-0.57%) ⬇️
...ification/notifiers/checks/checks_with_fallback.py 87.50% <ø> (-10.00%) ⬇️
...s/notification/notifiers/tests/unit/test_checks.py 100.00% <100.00%> (ø)
...tification/tests/unit/test_notification_service.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes