Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for token from yaml #227

Merged
merged 1 commit into from
Jul 21, 2021
Merged

feat: Allow for token from yaml #227

merged 1 commit into from
Jul 21, 2021

Conversation

thomasrockhu
Copy link
Contributor

fixes codecov/codecov-action#430
related #222
related #219
related #217

@thomasrockhu thomasrockhu requested a review from a team July 21, 2021 05:20
@thomasrockhu thomasrockhu force-pushed the fix-token-from-yaml branch 4 times, most recently from 9b17521 to 22978ea Compare July 21, 2021 05:27
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #227 (a2e5f4f) into master (3e1beda) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   94.43%   94.63%   +0.20%     
==========================================
  Files          22       23       +1     
  Lines         772      801      +29     
  Branches      141      144       +3     
==========================================
+ Hits          729      758      +29     
  Misses         12       12              
  Partials       31       31              
Flag Coverage Δ
alpine 94.63% <100.00%> (+0.20%) ⬆️
linux 94.63% <100.00%> (+0.20%) ⬆️
linux-without-git 94.63% <100.00%> (+0.20%) ⬆️
macos 94.63% <100.00%> (+0.20%) ⬆️
macos-without-git 94.63% <100.00%> (+0.20%) ⬆️
windows 94.00% <100.00%> (+0.22%) ⬆️
windows-without-git 94.00% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.js 94.36% <100.00%> (ø)
src/helpers/token.js 100.00% <100.00%> (ø)
src/index.js 84.70% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1beda...a2e5f4f. Read the comment docs.

package.json Show resolved Hide resolved
@thomasrockhu thomasrockhu merged commit e9cfaf5 into master Jul 21, 2021
@thomasrockhu thomasrockhu deleted the fix-token-from-yaml branch July 21, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 fails to upload coverage
2 participants