feat: Add img component for light and dark src #3675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 826 +1
Lines 14892 14897 +5
Branches 4233 4242 +9
=======================================
+ Hits 14716 14721 +5
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 826 +1
Lines 14892 14897 +5
Branches 4241 4234 -7
=======================================
+ Hits 14716 14721 +5
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 38 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 826 +1
Lines 14892 14897 +5
Branches 4241 4234 -7
=======================================
+ Hits 14716 14721 +5
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
| const renderWithTheme = (ui: React.ReactElement, theme: Theme) => { | ||
| return render( | ||
| <ThemeContext.Provider value={{ theme, setTheme: vi.fn() }}> | ||
| {ui} | ||
| </ThemeContext.Provider> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Thoughts on converting this to a wrapper component, similar to how we do it in other tests?
Bundle ReportChanges will increase total bundle size by 12.42MB (100.0%) ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 826 +1
Lines 14892 14897 +5
Branches 4241 4242 +1
=======================================
+ Hits 14716 14721 +5
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Description
Closes codecov/engineering-team#2812
Code Example
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.