Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bundle cache modal to repo config tab #3655

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Jan 13, 2025

Description

Note

This PR requires #3652 before reviewing/merging

This PR adds in a button to the repo config tab that toggles the newly bundle caching modal, that is hidden behind a feature flag.

Ticket: codecov/engineering-team#3157

Notable Changes

  • Add in button and modal to ConfigurationManager component
  • Add in new tests

Screenshots

Screenshot 2025-01-13 at 15 00 08

Copy link

codecov bot commented Jan 13, 2025

Bundle Report

Changes will increase total bundle size by 19.69kB (0.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.05MB 9.74kB (0.16%) ⬆️
gazebo-production-esm 6.1MB 9.95kB (0.16%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tabs/ConfigurationManager/ConfigurationManager.tsx 80.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #3655      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14676    14681       +5     
  Branches     4156     4158       +2     
==========================================
+ Hits        14521    14525       +4     
- Misses        148      149       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 96.87% <80.00%> (-3.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <80.00%> (-0.02%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b4e9...e81519d. Read the comment docs.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (333b4e9) to head (e81519d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tabs/ConfigurationManager/ConfigurationManager.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3655      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14676    14681       +5     
  Branches     4164     4158       -6     
==========================================
+ Hits        14521    14525       +4     
- Misses        148      149       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 96.87% <80.00%> (-3.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <80.00%> (-0.02%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b4e9...e81519d. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (333b4e9) to head (e81519d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tabs/ConfigurationManager/ConfigurationManager.tsx 80.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #3655      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14676    14681       +5     
  Branches     4164     4158       -6     
==========================================
+ Hits        14521    14525       +4     
- Misses        148      149       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 96.87% <80.00%> (-3.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <80.00%> (-0.02%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b4e9...e81519d. Read the comment docs.

Copy link

Codecov Report

Attention: Patch coverage is 98.57143% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (6807f02) to head (cb76b24).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tabs/ConfigurationManager/ConfigurationManager.tsx 80.00% 1 Missing ⚠️
@@           Coverage Diff           @@
##             main    #3655   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         814      815    +1     
  Lines       14612    14681   +69     
  Branches     4151     4166   +15     
=======================================
+ Hits        14456    14525   +69     
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <100.00%> (ø)
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 96.87% <80.00%> (-3.13%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <98.48%> (-0.01%) ⬇️
Services 99.34% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (+0.06%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6807f02...cb76b24. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 13, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
cb76b24 Mon, 13 Jan 2025 19:07:16 GMT Expired Expired
e81519d Tue, 14 Jan 2025 19:41:51 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov force-pushed the gh-eng-3157-feat-add-bundle-cache-modal-to-repo-config-tab branch from cb76b24 to e81519d Compare January 14, 2025 19:36
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 12d8acb Jan 15, 2025
49 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3157-feat-add-bundle-cache-modal-to-repo-config-tab branch January 15, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants