-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bundle cache modal to repo config tab #3655
feat: Add bundle cache modal to repo config tab #3655
Conversation
Bundle ReportChanges will increase total bundle size by 19.69kB (0.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3655 +/- ##
==========================================
- Coverage 98.94% 98.93% -0.01%
==========================================
Files 815 815
Lines 14676 14681 +5
Branches 4156 4158 +2
==========================================
+ Hits 14521 14525 +4
- Misses 148 149 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3655 +/- ##
==========================================
- Coverage 98.94% 98.93% -0.01%
==========================================
Files 815 815
Lines 14676 14681 +5
Branches 4164 4158 -6
==========================================
+ Hits 14521 14525 +4
- Misses 148 149 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3655 +/- ##
==========================================
- Coverage 98.94% 98.93% -0.01%
==========================================
Files 815 815
Lines 14676 14681 +5
Branches 4164 4158 -6
==========================================
+ Hits 14521 14525 +4
- Misses 148 149 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3655 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 814 815 +1
Lines 14612 14681 +69
Branches 4151 4166 +15
=======================================
+ Hits 14456 14525 +69
Misses 149 149
Partials 7 7
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
cb76b24
to
e81519d
Compare
Description
Note
This PR requires #3652 before reviewing/mergingThis PR adds in a button to the repo config tab that toggles the newly bundle caching modal, that is hidden behind a feature flag.
Ticket: codecov/engineering-team#3157
Notable Changes
ConfigurationManager
componentScreenshots