fix: Remove "to" prop if component is <a> #3654
Conversation
| @@ -33,9 +33,7 @@ function useCompleteProps( | |||
|
|
|||
| const propsLink = pageConfig?.isExternalLink | |||
| ? { href: path } | |||
| : Component === 'a' | |||
There was a problem hiding this comment.
this is just the same thing as isExternalLink being defined
There was a problem hiding this comment.
At least from testing this looked to be the case
Bundle ReportChanges will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 22 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 814 814
Lines 14612 14611 -1
Branches 4151 4143 -8
=======================================
Hits 14456 14456
+ Misses 149 148 -1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3654 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 814 814
Lines 14612 14611 -1
Branches 4144 4150 +6
=======================================
Hits 14456 14456
+ Misses 149 148 -1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3654 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 814 814
Lines 14612 14611 -1
Branches 4151 4143 -8
=======================================
Hits 14456 14456
+ Misses 149 148 -1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Fixing a console issue @nicholas-codecov found while developing locally. A tags don't allow you to have a "to" prop on them
This PR removes / clears out the to prop if it exists and the component is an tag.
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.