dev: Update TS from 4.9.5 -> ~5.7.3 #3647
Conversation
| const propsLink = pageConfig?.isExternalLink ? { href: path } : { to: path } | ||
| const propsLink = pageConfig?.isExternalLink | ||
| ? { href: path } | ||
| : Component === 'a' |
There was a problem hiding this comment.
"a" link wasn't accounted for previously, now it is
| @@ -23,7 +27,9 @@ function Breadcrumb({ paths = [], largeFont = false }) { | |||
| {defaultTo(to.children, to.text)} | |||
| </span> | |||
| ) : ( | |||
| <A to={to}>{defaultTo(to.children, to.text)}</A> | |||
| <A to={to} hook={undefined} isExternal={false}> | |||
There was a problem hiding this comment.
just set these to undefined to preserve original behavior
ajay-sentry
changed the title
Bundle ReportChanges will decrease total bundle size by 34 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 98.95% 98.94% -0.01%
==========================================
Files 813 813
Lines 14599 14600 +1
Branches 4146 4148 +2
==========================================
Hits 14446 14446
- Misses 146 147 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 98.95% 98.94% -0.01%
==========================================
Files 813 813
Lines 14599 14600 +1
Branches 4146 4148 +2
==========================================
Hits 14446 14446
- Misses 146 147 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 98.95% 98.94% -0.01%
==========================================
Files 813 813
Lines 14599 14600 +1
Branches 4139 4148 +9
==========================================
Hits 14446 14446
- Misses 146 147 +1
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 34 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
changed the title
Description
This PR bumps TS from ^4.9.5 -> ~5.7.3, effectively "pinning" TS to 5.7 so we can be particular about bumping up to 5.8 and later. This is because TS sometimes has breaking changes between minor versions.
For reference, TS 4.9.5 was released January 31st 2023, so we're getting around 2 years worth of version updates with this PR :)
Changelog
Whats new (up til 5.5... I used to like reading these "spark notes" but I guess they stopped doing this since 5.6) -> https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-0.html
Some of my favorite highlights from this TS update:
and a WHOLE BUNCH more
Screen.Recording.2025-01-10.at.10.29.49.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.