-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fetch isCached Field with CommitPageDataQueryOpts - Round 2 #3631
feat: Fetch isCached Field with CommitPageDataQueryOpts - Round 2 #3631
Conversation
Bundle ReportChanges will increase total bundle size by 368 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 736 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14564 +2
Branches 4148 4148
=======================================
+ Hits 14414 14416 +2
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3631 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14564 +2
Branches 4148 4141 -7
=======================================
+ Hits 14414 14416 +2
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3631 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 810 810
Lines 14562 14564 +2
Branches 4148 4141 -7
=======================================
+ Hits 14414 14416 +2
Misses 141 141
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR updates the query for
CommitPageDataQueryOpts
to grab theisCached
field which will be used in a later PR to create a banner informing the user that there is data in the commit that has been cached from a previous commit.Ticket: codecov/engineering-team#3152
Note
This is the second iteration of this PR, as the previous one had an issue with the Zod validation schema and how it handled the union type. This has been resolved in this PR.
Before:
After:
Notable Changes
CommitPageDataQueryOpts
query and validation schema