Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch isCached Field with CommitPageDataQueryOpts - Round 2 #3631

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the query for CommitPageDataQueryOpts to grab the isCached field which will be used in a later PR to create a banner informing the user that there is data in the commit that has been cached from a previous commit.

Ticket: codecov/engineering-team#3152

Note

This is the second iteration of this PR, as the previous one had an issue with the Zod validation schema and how it handled the union type. This has been resolved in this PR.
Before:

const BundleAnalysisReportSchema = z.object({
 __typename: z.literal('BundleAnalysisReport'),
 isCached: z.boolean(),
})

const BundleAnalysisReportUnion = z.union([
 BundleAnalysisReportSchema,
 MissingHeadReportSchema.shape.__typename,
])

After:

const BundleAnalysisReportSchema = z.object({
 __typename: z.literal('BundleAnalysisReport'),
 isCached: z.boolean(),
})

const BundleAnalysisReportUnion = z.discriminatedUnion('__typename', [
 BundleAnalysisReportSchema,
 z.object({ __typename: MissingHeadReportSchema.shape.__typename }),
])

Notable Changes

  • Update CommitPageDataQueryOpts query and validation schema
  • Update MSW mock responses

Copy link

codecov bot commented Jan 6, 2025

Bundle Report

Changes will increase total bundle size by 368 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system-esm 6.06MB 368 bytes (0.01%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Jan 6, 2025

Bundle Report

Changes will increase total bundle size by 736 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 368 bytes (0.01%) ⬆️
gazebo-staging-system 6.0MB 368 bytes (0.01%) ⬆️

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (0d5e832) to head (5d3d307).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3631   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14564    +2     
  Branches     4148     4148           
=======================================
+ Hits        14414    14416    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5e832...5d3d307. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3631   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14564    +2     
  Branches     4148     4141    -7     
=======================================
+ Hits        14414    14416    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5e832...5d3d307. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (0d5e832) to head (5d3d307).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3631   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      810           
  Lines       14562    14564    +2     
  Branches     4148     4141    -7     
=======================================
+ Hits        14414    14416    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...mmitDetailPage/queries/CommitPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5e832...5d3d307. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
5d3d307 Mon, 06 Jan 2025 11:56:58 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 9807408 Jan 6, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3152-feat-fetch-isCached-field-in-commit-page-data branch January 6, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants