fix: Resolve Sentry issue fetching in MissingDesignatedAdmins Without a Provider #3612
Conversation
Bundle ReportChanges will increase total bundle size by 354 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 354 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3612 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14553 +4
Branches 4150 4142 -8
=======================================
+ Hits 14404 14408 +4
Misses 138 138
Partials 7 7
... and 7 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3612 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14553 +4
Branches 4143 4142 -1
=======================================
+ Hits 14404 14408 +4
Misses 138 138
Partials 7 7
... and 7 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3612 +/- ##
==========================================
- Coverage 99.00% 99.00% -0.01%
==========================================
Files 810 810
Lines 14549 14548 -1
Branches 4150 4150
==========================================
- Hits 14404 14403 -1
Misses 138 138
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3612 +/- ##
=======================================
Coverage 99.00% 99.00%
=======================================
Files 810 810
Lines 14549 14553 +4
Branches 4150 4142 -8
=======================================
+ Hits 14404 14408 +4
Misses 138 138
Partials 7 7
... and 7 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
|
|
||
| if (hideBanner) { | ||
| if (!config.IS_SELF_HOSTED || !provider || hasAdmins || isFetching) { |
There was a problem hiding this comment.
we no longer need this !provider check either right?
There was a problem hiding this comment.
Nice catch, yea we can get rid of it, just a left over from a copy paste 🫣
nicholas-codecov
deleted the
fix-issue-with-not-conditionally-fetching-in-missing-designated-admins
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
This PR aims to resolve this Sentry issue, which is caused by the
providernot being defined as there are some cases where theGlobalBannerscan be rendered when no provider is present.I've updated the Gazebo Guidelines to cover these cases specifically.
Notable Changes
MissingDesignatedAdminsto conditionally fetch