ref: Migrate off "Plan" object from accountDetails REST endpoint to GQL Plan #3597
Conversation
… all references to it
This reverts commit b4aa950.
…into plans for the upgrade controllers
…rm, confirm with testing
…te-off-account-details-plan
| planAutoActivate: z.boolean().nullable(), | ||
| planProvider: z.string().nullable(), | ||
| repoTotalCredits: z.number(), | ||
| rootOrganization: z | ||
| .object({ | ||
| plan: PlanSchema, | ||
| username: z.string().nullish(), |
There was a problem hiding this comment.
Bundle ReportChanges will decrease total bundle size by 452 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3597 +/- ##
==========================================
- Coverage 99.01% 99.01% -0.01%
==========================================
Files 809 809
Lines 14549 14548 -1
Branches 4140 4146 +6
==========================================
- Hits 14406 14405 -1
Misses 136 136
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3597 +/- ##
==========================================
- Coverage 99.01% 99.01% -0.01%
==========================================
Files 809 809
Lines 14549 14548 -1
Branches 4147 4139 -8
==========================================
- Hits 14406 14405 -1
Misses 136 136
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3597 +/- ##
==========================================
- Coverage 99.01% 99.01% -0.01%
==========================================
Files 809 809
Lines 14549 14548 -1
Branches 4140 4146 +6
==========================================
- Hits 14406 14405 -1
Misses 136 136
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3597 +/- ##
==========================================
- Coverage 99.01% 99.01% -0.01%
==========================================
Files 809 809
Lines 14549 14548 -1
Branches 4140 4139 -1
==========================================
- Hits 14406 14405 -1
Misses 136 136
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will decrease total bundle size by 452 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
src/shared/utils/upgradeForm.test.ts
Outdated
| const accountDetails = { | ||
| plan: { value: Plans.USERS_BASIC, quantity: 1 }, | ||
| } as z.infer<typeof AccountDetailsSchema> | ||
| const accountDetails = {} as z.infer<typeof AccountDetailsSchema> |
There was a problem hiding this comment.
could just define this once in the top of the file
There was a problem hiding this comment.
good point, cleaned it up in 91efa0a
Description
This PR aims to remove all the instances of accountDetails?.plan and similar, as well as removing that object from the accountDetails zod schema as well; to effectively prevent folks in Gazebo from continuing to use that as a SOT for plan data moving forward.
This needs to be done prior to us doing the API side of removing the plan object from the REST endpoint to avoid breaking Gazebo otherwise.
Closes codecov/engineering-team#3126
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.