Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate useInfiniteAccountOrganizations to TS Query V5 #3569

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useInfiniteAccountOrganizations hook to the TS Query V5 infiniteQueryOptions version InfiniteAccountOrganizationsQueryOpts

Ticket: codecov/engineering-team#2968

Notable Changes

  • Migrates useInfiniteAccountOrganizations to InfiniteAccountOrganizationsQueryOpts
  • Update usage in AccountOrgs
  • Create/Update tests

@nicholas-codecov nicholas-codecov changed the title chore: Migrate useInfiniteAccountOrganizations to tsqv5 query options chore: Migrate useInfiniteAccountOrganizations to TS Query V5 Dec 11, 2024
@codecov-staging
Copy link

codecov-staging bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 798 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 381 bytes (0.01%) ⬆️
gazebo-staging-system 5.67MB 417 bytes (0.01%) ⬆️

Copy link

codecov bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 798 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 417 bytes (0.01%) ⬆️
gazebo-production-system-esm 5.72MB 381 bytes (0.01%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14485    +1     
  Branches     4108     4109    +1     
=======================================
+ Hits        14326    14327    +1     
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...7a6e097. Read the comment docs.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (0899f21) to head (7a6e097).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14485    +1     
  Branches     4115     4109    -6     
=======================================
+ Hits        14326    14327    +1     
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...7a6e097. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (0899f21) to head (7a6e097).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14485    +1     
  Branches     4108     4116    +8     
=======================================
+ Hits        14326    14327    +1     
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...7a6e097. Read the comment docs.

Copy link

codecov-public-qa bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (0899f21) to head (7a6e097).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14485    +1     
  Branches     4115     4116    +1     
=======================================
+ Hits        14326    14327    +1     
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...bRoutes/CurrentOrgPlan/AccountOrgs/AccountOrgs.tsx 100.00% <100.00%> (ø)
...n/queries/InfiniteAccountOrganizationsQueryOpts.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...7a6e097. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7a6e097 Wed, 11 Dec 2024 18:41:22 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit c729790 Dec 11, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2968-migrate-useInfiniteAccountOrganizations-to-tsqv5-queryOptions branch December 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants