Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate usePlanPageData to TS Query V5 #3567

Merged
merged 4 commits into from
Dec 11, 2024
Merged

chore: Migrate usePlanPageData to TS Query V5 #3567

merged 4 commits into from
Dec 11, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the usePlanPageData to the TS Query V5 queryOptions API version PlanPageDataQueryOpts

Ticket: codecov/engineering-team#2968

Notable Changes

  • Migrates usePlanPageData to PlanPageDataQueryOpts
  • Update usage of PlanPageDataQueryOpts
    • PlanPage
    • FreePlanCard
    • PaidPlanCard
  • Create/Update tests

@codecov-staging
Copy link

codecov-staging bot commented Dec 11, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 308 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 153 bytes (0.0%) ⬆️
gazebo-staging-system 5.67MB 155 bytes (0.0%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Dec 11, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3567   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14484           
  Branches     4108     4115    +7     
=======================================
  Hits        14326    14326           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <100.00%> (ø)
...rc/pages/PlanPage/queries/PlanPageDataQueryOpts.ts 100.00% <100.00%> (ø)
...Plan/CurrentPlanCard/FreePlanCard/FreePlanCard.jsx 100.00% <100.00%> (ø)
...Plan/CurrentPlanCard/PaidPlanCard/PaidPlanCard.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...38b4a8c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 11, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5639 1 5638 0
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions > when rendered > planString is set to annual plan > renders annual button as "selected"
Stack Traces | 0.201s run time 
Error: expect(element).toHaveClass("bg-ds-primary-base")

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (0899f21) to head (38b4a8c).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3567   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14484    14484           
  Branches     4115     4115           
=======================================
  Hits        14326    14326           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <100.00%> (ø)
...rc/pages/PlanPage/queries/PlanPageDataQueryOpts.ts 100.00% <100.00%> (ø)
...Plan/CurrentPlanCard/FreePlanCard/FreePlanCard.jsx 100.00% <100.00%> (ø)
...Plan/CurrentPlanCard/PaidPlanCard/PaidPlanCard.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899f21...38b4a8c. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Bundle Report

Changes will increase total bundle size by 308 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 155 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.72MB 153 bytes (0.0%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5639 1 5638 0
View the top 1 failed tests by shortest run time 
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions > when rendered > planString is set to annual plan > renders annual button as "selected"
Stack Traces | 0.201s run time 
Error: expect(element).toHaveClass("bg-ds-primary-base")

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
38b4a8c Wed, 11 Dec 2024 18:30:07 GMT Cloud Enterprise

spalmurray-codecov
spalmurray-codecov reviewed Dec 11, 2024
View reviewed changes
src/pages/PlanPage/queries/PlanPageDataQueryOpts.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love how easy this is

spalmurray-codecov
spalmurray-codecov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like coverage data is maybe off though?

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 0993878 Dec 11, 2024
51 of 54 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2968-chore-migrate-usePlanPageData-to-tsqv5 branch December 11, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov