Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken tests when custom GH_APP set locally #3558

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Was testing our the new changes to GH_APP and found some tests breaking when I had the config value set locally. This PR fixes those tests.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review December 5, 2024 15:52
Copy link

codecov bot commented Dec 5, 2024

Bundle Report

Changes will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.66MB 11 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 5.66MB 11 bytes (-0.0%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3558   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14475    14475           
  Branches     4118     4111    -7     
=======================================
  Hits        14317    14317           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636cbf3...1d405f8. Read the comment docs.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (636cbf3) to head (1d405f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3558   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14475    14475           
  Branches     4118     4118           
=======================================
  Hits        14317    14317           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636cbf3...1d405f8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (636cbf3) to head (1d405f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3558   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14475    14475           
  Branches     4118     4111    -7     
=======================================
  Hits        14317    14317           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636cbf3...1d405f8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1d405f8 Thu, 05 Dec 2024 15:58:19 GMT Cloud Enterprise

Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh sorry about that - thank you so much for fixing!!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 354e880 Dec 5, 2024
61 of 62 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-custom-gh-app-breaks-tests branch December 5, 2024 17:43
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (636cbf3) to head (1d405f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3558   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14475    14475           
  Branches     4118     4111    -7     
=======================================
  Hits        14317    14317           
  Misses        151      151           
  Partials        7        7           
Files with missing lines Coverage Δ
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636cbf3...1d405f8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants