-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Broken tests when custom GH_APP set locally #3558
fix: Broken tests when custom GH_APP set locally #3558
Conversation
Bundle ReportChanges will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 11 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14475 14475
Branches 4118 4111 -7
=======================================
Hits 14317 14317
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14475 14475
Branches 4118 4118
=======================================
Hits 14317 14317
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14475 14475
Branches 4118 4111 -7
=======================================
Hits 14317 14317
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh sorry about that - thank you so much for fixing!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 806 806
Lines 14475 14475
Branches 4118 4111 -7
=======================================
Hits 14317 14317
Misses 151 151
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Was testing our the new changes to
GH_APP
and found some tests breaking when I had the config value set locally. This PR fixes those tests.