-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Paginate files/dir list in repo overview page #3556
Conversation
Bundle ReportChanges will increase total bundle size by 4.71kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 4.71kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 810 810
Lines 14563 14576 +13
Branches 4145 4147 +2
==========================================
+ Hits 14404 14416 +12
- Misses 152 153 +1
Partials 7 7
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3556 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 810 810
Lines 14563 14576 +13
Branches 4152 4154 +2
==========================================
+ Hits 14404 14416 +12
- Misses 152 153 +1
Partials 7 7
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3556 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 810 810
Lines 14563 14576 +13
Branches 4145 4147 +2
==========================================
+ Hits 14404 14416 +12
- Misses 152 153 +1
Partials 7 7
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3556 +/- ##
==========================================
- Coverage 98.90% 98.90% -0.01%
==========================================
Files 810 810
Lines 14563 14576 +13
Branches 4152 4147 -5
==========================================
+ Hits 14404 14416 +12
- Misses 152 153 +1
Partials 7 7
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested and seems to be working as expected
Description
Finally migrating overview files list/tree to use pagination.
Notable Changes
Screenshots
Screen.Recording.2024-12-05.at.3.02.58.PM.mov
[Gazebo] Migrate existing hooks to using the new array pagination connection
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.