Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Paginate files/dir list in repo overview page #3556

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Dec 5, 2024

Description

Finally migrating overview files list/tree to use pagination.

Notable Changes

  • Updated useRepoBranchContents
  • Updated prefetch contents hook
  • Updated files list table
  • Updated dir list table

Screenshots

Screen.Recording.2024-12-05.at.3.02.58.PM.mov

[Gazebo] Migrate existing hooks to using the new array pagination connection

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Dec 5, 2024

Bundle Report

Changes will increase total bundle size by 4.71kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 2.2kB (0.04%) ⬆️
gazebo-production-system-esm 6.05MB 2.52kB (0.04%) ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Dec 5, 2024

Bundle Report

Changes will increase total bundle size by 4.71kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.05MB 2.52kB (0.04%) ⬆️
gazebo-staging-system 6.0MB 2.2kB (0.04%) ⬆️

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (400d724) to head (c83d01f).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         810      810              
  Lines       14563    14576      +13     
  Branches     4145     4147       +2     
==========================================
+ Hits        14404    14416      +12     
- Misses        152      153       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.tsx 100.00% <100.00%> (ø)
.../FileExplorer/hooks/useRepoBranchContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/branch/dir/constants.ts 100.00% <ø> (ø)
...hContents/branch/dir/usePrefetchBranchDirEntry.tsx 100.00% <100.00%> (ø)
.../pathContents/branch/dir/useRepoBranchContents.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (+<0.01%) ⬆️
Shared 99.32% <ø> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400d724...c83d01f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         810      810              
  Lines       14563    14576      +13     
  Branches     4152     4154       +2     
==========================================
+ Hits        14404    14416      +12     
- Misses        152      153       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.tsx 100.00% <100.00%> (ø)
.../FileExplorer/hooks/useRepoBranchContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/branch/dir/constants.ts 100.00% <ø> (ø)
...hContents/branch/dir/usePrefetchBranchDirEntry.tsx 100.00% <100.00%> (ø)
.../pathContents/branch/dir/useRepoBranchContents.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (+<0.01%) ⬆️
Shared 99.32% <ø> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400d724...c83d01f. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (400d724) to head (c83d01f).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         810      810              
  Lines       14563    14576      +13     
  Branches     4145     4147       +2     
==========================================
+ Hits        14404    14416      +12     
- Misses        152      153       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.tsx 100.00% <100.00%> (ø)
.../FileExplorer/hooks/useRepoBranchContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/branch/dir/constants.ts 100.00% <ø> (ø)
...hContents/branch/dir/usePrefetchBranchDirEntry.tsx 100.00% <100.00%> (ø)
.../pathContents/branch/dir/useRepoBranchContents.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (+<0.01%) ⬆️
Shared 99.32% <ø> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400d724...c83d01f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Dec 5, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
16a52e2 Thu, 05 Dec 2024 13:47:11 GMT Expired Expired
5f793a0 Thu, 05 Dec 2024 14:03:57 GMT Expired Expired
9e4d125 Mon, 16 Dec 2024 11:28:58 GMT Expired Expired
c83d01f Wed, 18 Dec 2024 10:24:17 GMT Cloud Enterprise

@RulaKhaled RulaKhaled marked this pull request as ready for review December 5, 2024 14:06
@RulaKhaled RulaKhaled changed the title feat: Paginate files list in repo overview page feat: Paginate files/dir list in repo overview page Dec 5, 2024
Copy link

codecov-public-qa bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (400d724) to head (c83d01f).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3556      +/-   ##
==========================================
- Coverage   98.90%   98.90%   -0.01%     
==========================================
  Files         810      810              
  Lines       14563    14576      +13     
  Branches     4152     4147       -5     
==========================================
+ Hits        14404    14416      +12     
- Misses        152      153       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
...route/FileExplorer/CodeTreeTable/CodeTreeTable.tsx 100.00% <100.00%> (ø)
...route/FileExplorer/FileListTable/FileListTable.tsx 100.00% <100.00%> (ø)
.../FileExplorer/hooks/useRepoBranchContentsTable.tsx 100.00% <100.00%> (ø)
src/services/pathContents/branch/dir/constants.ts 100.00% <ø> (ø)
...hContents/branch/dir/usePrefetchBranchDirEntry.tsx 100.00% <100.00%> (ø)
.../pathContents/branch/dir/useRepoBranchContents.tsx 100.00% <100.00%> (ø)
src/services/pathContents/commit/dir/constants.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.57% <100.00%> (-0.02%) ⬇️
Services 99.36% <100.00%> (+<0.01%) ⬆️
Shared 99.32% <ø> (-0.01%) ⬇️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400d724...c83d01f. Read the comment docs.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested and seems to be working as expected

@RulaKhaled RulaKhaled enabled auto-merge December 18, 2024 09:55
@RulaKhaled RulaKhaled added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 5dfae65 Dec 18, 2024
62 checks passed
@RulaKhaled RulaKhaled deleted the paginate-files-list branch December 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants