fix: Seperate org name from error banner on 404 page #3525

nicholas-codecov · 2024-11-25T13:15:57Z

Description

This PR updates a couple things in the BaseLayout, Header, Navigator, and GlobalTopBanners to maintain previously resolved issues, and codecov/engineering-team#2830.

Closes codecov/engineering-team#2830

Notable Changes

Create new hook to determine information for the Navigator component
Update logic in the Navigator to handle new cases
- Repo Page
  - User has access to repo -> render breadcrumb
  - User and Owner exist but private repo -> render context switcher (so they can escape)
  - None of the above -> render nothing (there is the guest header as their escape hatch)
- Any page when the user is not logged in and owner does exist
  - Render the context switcher
- User not logged in and org doesn't exist -> don't render anything (guest header is the escape hatch)
Wrap each banner in GlobalTopBanners to have their own SilentNetworkErrorWrapper
Fetch data, and pass down from BaseLayout
Create/Update tests
- Had to rework the wrapper in the Navigator tests as paths were being rendered even if they didn't match

Screenshots

Updated private repo page

codecov-staging · 2024-11-25T13:18:20Z

Bundle Report

Changes will decrease total bundle size by 21.0kB (-0.12%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.71MB	10.14kB (-0.18%) ⬇️
gazebo-staging-system	5.66MB	10.86kB (-0.19%) ⬇️

codecov · 2024-11-25T13:19:16Z

Bundle Report

Changes will decrease total bundle size by 21.0kB (-0.12%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.66MB	10.86kB (-0.19%) ⬇️
gazebo-production-system-esm	5.71MB	10.14kB (-0.18%) ⬇️

codecov-qa · 2024-11-25T13:19:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (67b950a) to head (76a076e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3525      +/-   ##
==========================================
- Coverage   98.92%   98.90%   -0.02%     
==========================================
  Files         806      807       +1     
  Lines       14447    14476      +29     
  Branches     4098     4109      +11     
==========================================
+ Hits        14291    14318      +27     
- Misses        149      151       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx	`100.00% <100.00%> (ø)`
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts	`100.00% <100.00%> (ø)`
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`97.22% <100.00%> (-2.78%)`	⬇️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx	`100.00% <ø> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`97.95% <100.00%> (-2.05%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <100.00%> (-0.29%)`	⬇️
Pages	`98.59% <ø> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.14% <100.00%> (-0.08%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...76a076e. Read the comment docs.

codecov · 2024-11-25T13:21:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (67b950a) to head (76a076e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3525      +/-   ##
==========================================
- Coverage   98.92%   98.90%   -0.02%     
==========================================
  Files         806      807       +1     
  Lines       14447    14476      +29     
  Branches     4098     4109      +11     
==========================================
+ Hits        14291    14318      +27     
- Misses        149      151       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx	`100.00% <100.00%> (ø)`
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts	`100.00% <100.00%> (ø)`
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`97.22% <100.00%> (-2.78%)`	⬇️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx	`100.00% <ø> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`97.95% <100.00%> (-2.05%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <100.00%> (-0.29%)`	⬇️
Pages	`98.59% <ø> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.14% <100.00%> (-0.08%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...76a076e. Read the comment docs.

codecov-releaser · 2024-11-25T13:22:59Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`e326a30`	Mon, 25 Nov 2024 13:22:58 GMT	Expired	Expired
`9b21dfc`	Mon, 25 Nov 2024 13:29:05 GMT	Expired	Expired
`581a69e`	Mon, 25 Nov 2024 13:45:33 GMT	Expired	Expired
`514500e`	Mon, 25 Nov 2024 15:02:31 GMT	Expired	Expired
`3702525`	Mon, 25 Nov 2024 16:10:57 GMT	Expired	Expired
`074001d`	Wed, 27 Nov 2024 17:08:23 GMT	Expired	Expired
`5bb65c4`	Thu, 28 Nov 2024 11:45:06 GMT	Expired	Expired
`4a29705`	Mon, 02 Dec 2024 16:21:15 GMT	Expired	Expired
`76a076e`	Mon, 02 Dec 2024 16:51:51 GMT	Cloud	Enterprise

nicholas-codecov · 2024-11-25T13:16:40Z

src/shared/GlobalTopBanners/GlobalTopBanners.tsx

+        <SilentNetworkErrorWrapper>
+          <OktaBanners />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <RequestInstallBanner />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <TrialBanner />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <TeamPlanFeedbackBanner />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <ProPlanFeedbackBanner />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <BundleFeedbackBanner />
+        </SilentNetworkErrorWrapper>
+
+        <SilentNetworkErrorWrapper>
+          <TokenlessBanner />
+        </SilentNetworkErrorWrapper>


Switching this up, so that we're able to show some banners and not others, for instance if we're on a repo that the user needs to auth with Okta with, before this would just hide all the banners.

nicholas-codecov · 2024-11-25T13:17:34Z

src/layouts/Header/components/Navigator/Navigator.tsx

+  // If the owner doesn't exist, don't show anything
+  if (!currentUser && ownerData) {


If the user is viewing an owner that doesn't exist, it just rendered the Avatar icon with a question mark, so just removing that entirely, but leaving in the user controls on the right hand side.

codecov-notifications · 2024-11-25T13:26:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3525      +/-   ##
==========================================
- Coverage   98.92%   98.90%   -0.02%     
==========================================
  Files         806      807       +1     
  Lines       14447    14476      +29     
  Branches     4105     4109       +4     
==========================================
+ Hits        14291    14318      +27     
- Misses        149      151       +2     
  Partials        7        7

Files with missing lines	Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx	`100.00% <100.00%> (ø)`
...layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts	`100.00% <100.00%> (ø)`
src/layouts/Header/Header.tsx	`100.00% <100.00%> (ø)`
.../layouts/Header/components/Navigator/Navigator.tsx	`97.22% <100.00%> (-2.78%)`	⬇️
src/shared/GlobalTopBanners/GlobalTopBanners.tsx	`100.00% <ø> (ø)`
src/ui/ContextSwitcher/ContextSwitcher.jsx	`97.95% <100.00%> (-2.05%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <100.00%> (-0.29%)`	⬇️
Pages	`98.59% <ø> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (ø)`
UI	`99.14% <100.00%> (-0.08%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...76a076e. Read the comment docs.

src/layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts

spalmurray-codecov

looks good. Seems like a lot of stuff is not covered according to my browser extension though

… hatch

…ve access to a repo

…ner-on-404-page

sentry-io · 2024-12-02T19:11:05Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: NetworkError when attempting to fetch resource. /:provider/:owner/:repo/pull/:pullId View Issue
‼️ TypeError: Importing a module script failed. /:provider/:owner/:repo View Issue
‼️ TypeError: Failed to fetch /:provider/:owner/:repo View Issue
‼️ TypeError: Load failed /:provider/:owner/:repo View Issue
‼️ TypeError: Failed to fetch /github/codecov/worker/blob/main/services%2Fnot... View Issue

_{Did you find this useful? React with a 👍 or 👎}

nicholas-codecov commented Nov 25, 2024

View reviewed changes

spalmurray-codecov reviewed Nov 27, 2024

View reviewed changes

src/layouts/BaseLayout/hooks/NavigatorDataQueryOpts.ts Show resolved Hide resolved

spalmurray-codecov approved these changes Nov 27, 2024

View reviewed changes

nicholas-codecov added 14 commits November 27, 2024 12:51

add in new query options for grabbing data for the Navigator

aee8355

update logic in Navigator to handle all cases

30970af

pass props through to Navigator

ccff770

update BaseLayout to fetch data for Navigator

e10d58e

add in v5 query client to app tests and navigator data mock

641168d

wrap each banner in their own silent network error wrapper

f2f550b

remove case where user doesn't belong to org as it removes the escape…

3336b43

… hatch

render the context switcher to the owner page if the user does not ha…

fe3f496

…ve access to a repo

rework logic a bit more

60dd83e

update tests as there were some issues with the routing in the wrapper

5c0ab53

render fallback only if the owner exists

5a2997a

add in test for failing to parse

2ae45bd

add some extra context in comment

501c32b

add tests where use belongs to org but doesn't have access to a repo

074001d

nicholas-codecov force-pushed the gh-eng-2830-seperate-org-name-from-error-banner-on-404-page branch from 0d38341 to 074001d Compare November 27, 2024 16:53

nicholas-codecov added 3 commits November 28, 2024 07:39

add in test for repo page user not being a vistor

5bb65c4

update ContextSwitcher to read owner param

662ce1b

render context select always even if there's no owner

4a29705

spalmurray-codecov approved these changes Dec 2, 2024

View reviewed changes

Merge branch 'main' into gh-eng-2830-seperate-org-name-from-error-ban…

76a076e

…ner-on-404-page

nicholas-codecov added this pull request to the merge queue Dec 2, 2024

Merged via the queue into main with commit 44255e7 Dec 2, 2024
58 of 62 checks passed

nicholas-codecov deleted the gh-eng-2830-seperate-org-name-from-error-banner-on-404-page branch December 2, 2024 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Seperate org name from error banner on 404 page #3525

fix: Seperate org name from error banner on 404 page #3525

nicholas-codecov commented Nov 25, 2024 •

edited

Loading

codecov-staging bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

codecov-qa bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

codecov-releaser commented Nov 25, 2024 •

edited

Loading

nicholas-codecov Nov 25, 2024

nicholas-codecov Nov 25, 2024

codecov-notifications bot commented Nov 25, 2024 •

edited

Loading

spalmurray-codecov left a comment

sentry-io bot commented Dec 2, 2024 •

edited

Loading

		// If the owner doesn't exist, don't show anything
		if (!currentUser && ownerData) {

fix: Seperate org name from error banner on 404 page #3525

fix: Seperate org name from error banner on 404 page #3525

Conversation

nicholas-codecov commented Nov 25, 2024 • edited Loading

Description

Notable Changes

Screenshots

codecov-staging bot commented Nov 25, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 25, 2024 • edited Loading

Bundle Report

codecov-qa bot commented Nov 25, 2024 • edited Loading

Codecov Report

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

codecov-releaser commented Nov 25, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

nicholas-codecov Nov 25, 2024

Choose a reason for hiding this comment

nicholas-codecov Nov 25, 2024

Choose a reason for hiding this comment

codecov-notifications bot commented Nov 25, 2024 • edited Loading

Codecov Report

spalmurray-codecov left a comment

Choose a reason for hiding this comment

sentry-io bot commented Dec 2, 2024 • edited Loading

Suspect Issues

nicholas-codecov commented Nov 25, 2024 •

edited

Loading

codecov-staging bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

codecov-qa bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

codecov-releaser commented Nov 25, 2024 •

edited

Loading

codecov-notifications bot commented Nov 25, 2024 •

edited

Loading

sentry-io bot commented Dec 2, 2024 •

edited

Loading