Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix link to custom gh app for self-hosted #3492

Merged
merged 5 commits into from
Dec 4, 2024
Merged

fix: Fix link to custom gh app for self-hosted #3492

merged 5 commits into from
Dec 4, 2024

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 13, 2024 •
edited
Loading

Self-hosted deployments (config.IS_SELF_HOSTED, for Dedicated Enterprise Cloud customers and self-hosted) cannot use the default GitHub codecov app that can be installed from this link: https://github.com/apps/codecov/installations/select_target

Instead, that slug codecov needs to be replaced by the custom GitHub app name as explained in our docs here
So something like https://github.com/apps/my-custom-app-name/installations/select_target
Note that the slug ("GitHub App Name") is a lowercase hyphen separated string version of the entered name

Update the "Install Codecov GitHub app" link in the header to redirect to the custom app based on the existing env var (REACT_APP_GH_APP=my-custom-app-name).

Screenshot 2024-11-12 at 6 25 07 PM

Closes codecov/engineering-team#2251

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 210 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.66MB 109 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.71MB 101 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 13, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 210 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.71MB 101 bytes (-0.0%) ⬇️
gazebo-staging-system 5.66MB 109 bytes (-0.0%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (c6a90fc) to head (5534d6c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3492   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14471    14475    +4     
  Branches     4117     4111    -6     
=======================================
+ Hits        14312    14317    +5     
+ Misses        152      151    -1     
  Partials        7        7
Files with missing lines Coverage Δ
src/config.js 95.00% <100.00%> (+0.26%) ⬆️
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
src/ui/ContextSwitcher/ContextSwitcher.tsx 98.03% <100.00%> (+2.20%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a90fc...5534d6c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Nov 13, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3492   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14471    14475    +4     
  Branches     4117     4118    +1     
=======================================
+ Hits        14312    14317    +5     
+ Misses        152      151    -1     
  Partials        7        7
Files with missing lines Coverage Δ
src/config.js 95.00% <100.00%> (+0.26%) ⬆️
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
src/ui/ContextSwitcher/ContextSwitcher.tsx 98.03% <100.00%> (+2.20%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a90fc...5534d6c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (c6a90fc) to head (5534d6c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3492   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14471    14475    +4     
  Branches     4110     4118    +8     
=======================================
+ Hits        14312    14317    +5     
+ Misses        152      151    -1     
  Partials        7        7
Files with missing lines Coverage Δ
src/config.js 95.00% <100.00%> (+0.26%) ⬆️
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
src/ui/ContextSwitcher/ContextSwitcher.tsx 98.03% <100.00%> (+2.20%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a90fc...5534d6c. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (c6a90fc) to head (5534d6c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3492   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14471    14475    +4     
  Branches     4110     4118    +8     
=======================================
+ Hits        14312    14317    +5     
+ Misses        152      151    -1     
  Partials        7        7
Files with missing lines Coverage Δ
src/config.js 95.00% <100.00%> (+0.26%) ⬆️
...rvices/navigation/useNavLinks/useStaticNavLinks.ts 98.88% <100.00%> (ø)
src/ui/ContextSwitcher/ContextSwitcher.tsx 98.03% <100.00%> (+2.20%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <100.00%> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a90fc...5534d6c. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 13, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d00f04d Wed, 13 Nov 2024 02:34:05 GMT Expired Expired
0363ea3 Wed, 13 Nov 2024 20:51:08 GMT Expired Expired
3720d49 Wed, 13 Nov 2024 21:05:06 GMT Expired Expired
230e407 Wed, 04 Dec 2024 22:04:21 GMT Expired Expired
5534d6c Wed, 04 Dec 2024 22:13:14 GMT Cloud Enterprise

@suejung-sentry
Copy link
Contributor Author

Removed the "Switch context" row per this convo

Screenshot 2024-11-13 at 2 27 13 PM

@suejung-sentry
Copy link
Contributor Author

I'll wait for this before merging this - https://github.com/codecov/internal-issues/issues/1073

@suejung-sentry suejung-sentry added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 2655e5b Dec 4, 2024
61 of 62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/gh-app-self-hosted branch December 4, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Self hosted] Add GH organization button links to cloud GH app, even when custom app is configured
3 participants
@suejung-sentry @codecov-releaser @spalmurray-codecov