-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Still show coverage charts if we have one data point #3490
Conversation
Bundle ReportChanges will decrease total bundle size by 14 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 14 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14354
Branches 4082 4075 -7
=======================================
Hits 14224 14224
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14354
Branches 4075 4075
=======================================
Hits 14224 14224
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14354
Branches 4082 4075 -7
=======================================
Hits 14224 14224
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3490 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 806 806
Lines 14354 14354
Branches 4075 4082 +7
=======================================
Hits 14224 14224
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: magic number
Description
Closes codecov/engineering-team#2676
The NoData and CoverageAreaChart components were removed as we now have new area chart components. Gist of desired change was to still show the chart even if there is only one point as it is still useful to the user and telling them there's not enough data can be misleading/confusing. With no points, we should continue showing the user that we don't have enough data.
Screenshots
Overview Tab chart:
Analytics chart: