Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Still show coverage charts if we have one data point #3490

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Nov 12, 2024

Description

Closes codecov/engineering-team#2676

The NoData and CoverageAreaChart components were removed as we now have new area chart components. Gist of desired change was to still show the chart even if there is only one point as it is still useful to the user and telling them there's not enough data can be misleading/confusing. With no points, we should continue showing the user that we don't have enough data.

Screenshots

Overview Tab chart:
Screenshot 2024-11-12 at 2 55 18 PM
Analytics chart:
Screenshot 2024-11-12 at 3 00 01 PM

@codecov-staging
Copy link

codecov-staging bot commented Nov 12, 2024

Bundle Report

Changes will decrease total bundle size by 14 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.61MB 59 bytes (0.0%) ⬆️
gazebo-staging-system 5.56MB 73 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 12, 2024

Bundle Report

Changes will decrease total bundle size by 14 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 73 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.61MB 59 bytes (0.0%) ⬆️

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (c6705f1) to head (c8f8773).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3490   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         806      806           
  Lines       14354    14354           
  Branches     4082     4075    -7     
=======================================
  Hits        14224    14224           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.tsx 87.50% <100.00%> (ø)
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.30% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.73% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6705f1...c8f8773. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3490   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         806      806           
  Lines       14354    14354           
  Branches     4075     4075           
=======================================
  Hits        14224    14224           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.tsx 87.50% <100.00%> (ø)
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.30% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.73% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6705f1...c8f8773. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (c6705f1) to head (c8f8773).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3490   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         806      806           
  Lines       14354    14354           
  Branches     4082     4075    -7     
=======================================
  Hits        14224    14224           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.tsx 87.50% <100.00%> (ø)
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.30% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.73% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6705f1...c8f8773. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (c6705f1) to head (c8f8773).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3490   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         806      806           
  Lines       14354    14354           
  Branches     4075     4082    +7     
=======================================
  Hits        14224    14224           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/Chart.tsx 87.50% <100.00%> (ø)
...erviewTab/subroute/CoverageChart/CoverageChart.tsx 91.30% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <100.00%> (ø)
Services 99.36% <ø> (ø)
Shared 99.73% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6705f1...c8f8773. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 12, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
aad1829 Tue, 12 Nov 2024 23:34:09 GMT Expired Expired
c8f8773 Thu, 14 Nov 2024 01:01:15 GMT Expired Expired
c8f8773 Thu, 14 Nov 2024 01:10:25 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: magic number

@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit fe14916 Nov 14, 2024
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/chart_not_enough_data branch November 14, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not enough data to display
3 participants