Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: New charts not getting the correct props on Analytics Page #3480

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: New charts not getting the correct props on Analytics Page #3480

merged 1 commit into from
Nov 8, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Quick fix to pass the correct props around.

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 341 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.54MB 8 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.59MB 349 bytes (-0.01%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (ba50b98) to head (d047386).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3480   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4015     4008    -7     
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba50b98...d047386. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (ba50b98) to head (d047386).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3480   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4015     4015           
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba50b98...d047386. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3480   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4008     4015    +7     
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba50b98...d047386. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (ba50b98) to head (d047386).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3480   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         802      802           
  Lines       14150    14150           
  Branches     4015     4008    -7     
=======================================
  Hits        14032    14032           
  Misses        111      111           
  Partials        7        7
Files Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba50b98...d047386. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 341 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.59MB 349 bytes (-0.01%) ⬇️
gazebo-staging-system 5.54MB 8 bytes (0.0%) ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d047386 Fri, 08 Nov 2024 19:05:15 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 424f106 Nov 8, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-chart-should-have-the-props-passed-not-chart-selectors branch November 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov