-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove VirtualDiff feature flag FilesChanged CommitDiff #3435
chore: Remove VirtualDiff feature flag FilesChanged CommitDiff #3435
Conversation
Bundle ReportChanges will increase total bundle size by 223 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 223 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 99.16% 99.15% -0.01%
==========================================
Files 809 809
Lines 14296 14297 +1
Branches 3948 3956 +8
==========================================
Hits 14176 14176
- Misses 111 112 +1
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 99.16% 99.15% -0.01%
==========================================
Files 809 809
Lines 14296 14297 +1
Branches 3955 3956 +1
==========================================
Hits 14176 14176
- Misses 111 112 +1
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 99.16% 99.15% -0.01%
==========================================
Files 809 809
Lines 14296 14297 +1
Branches 3955 3949 -6
==========================================
Hits 14176 14176
- Misses 111 112 +1
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3435 +/- ##
==========================================
- Coverage 99.16% 99.15% -0.01%
==========================================
Files 809 809
Lines 14296 14297 +1
Branches 3948 3956 +8
==========================================
Hits 14176 14176
- Misses 111 112 +1
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
…ople know what it's doing
ce377a3
to
2e19493
Compare
Description
This PR removes the virtual diff feature flag from the
CommitDiff
in theFilesChanged
directory of the commit details page. As well this PR refactors theCommitDiff
to TS, and some optimizations of data fetching hooks.Closes codecov/engineering-team#2729
Notable Changes
FilesChanged/CommitDiff
useComparisonForCommitAndParent
IndirectChanges/CommitDiff