Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Account usage banners to plan page #3381

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Oct 10, 2024

Adds seat usage banners for new multi org accounts using the useEnterpriseAccountDetails hook.

Design

Closes codecov/engineering-team#2561

Screenshot 2024-10-10 at 10 07 41 Screenshot 2024-10-10 at 10 08 33

@codecov-staging
Copy link

codecov-staging bot commented Oct 10, 2024

Bundle Report

Changes will increase total bundle size by 1.97kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push* 6.13MB 1.97kB (0.03%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov-public-qa bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (fff945c) to head (21228f1).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         803      803           
  Lines       14153    14166   +13     
  Branches     3899     3908    +9     
=======================================
+ Hits        14036    14049   +13     
  Misses        108      108           
  Partials        9        9           
Files Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.80% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <100.00%> (+<0.01%) ⬆️
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff945c...21228f1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         803      803           
  Lines       14153    14166   +13     
  Branches     3904     3908    +4     
=======================================
+ Hits        14036    14049   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.80% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <100.00%> (+<0.01%) ⬆️
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff945c...21228f1. Read the comment docs.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review October 10, 2024 14:08
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (fff945c) to head (21228f1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         803      803           
  Lines       14153    14166   +13     
  Branches     3904     3903    -1     
=======================================
+ Hits        14036    14049   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.80% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <100.00%> (+<0.01%) ⬆️
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff945c...21228f1. Read the comment docs.

Copy link

codecov bot commented Oct 10, 2024

Bundle Report

Changes will increase total bundle size by 1.97kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.13MB 1.97kB (0.03%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 10, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d1cc7b3 Thu, 10 Oct 2024 14:10:25 GMT Expired Expired
21228f1 Thu, 10 Oct 2024 15:05:43 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (fff945c) to head (21228f1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         803      803           
  Lines       14153    14166   +13     
  Branches     3899     3903    +4     
=======================================
+ Hits        14036    14049   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (ø)
...rvices/navigation/useNavLinks/useStaticNavLinks.js 98.80% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <100.00%> (+<0.01%) ⬆️
Services 99.45% <100.00%> (+<0.01%) ⬆️
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff945c...21228f1. Read the comment docs.

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this over to MSW mocks alongside your changes 🙏

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 3250f25 Oct 10, 2024
62 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/account-usage-banners branch October 10, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Create usage banners for multiple org plan page
4 participants