-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cleanup remaining MSW V1 things #3365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 799
Lines 14105 14105
Branches 3886 3891 +5
=======================================
Hits 13988 13988
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 799
Lines 14105 14105
Branches 3886 3886
=======================================
Hits 13988 13988
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 799
Lines 14105 14105
Branches 3891 3886 -5
=======================================
Hits 13988 13988
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3365 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 799
Lines 14105 14105
Branches 3891 3886 -5
=======================================
Hits 13988 13988
Misses 108 108
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR cleans up the remainder of things using MSW V1, once merged I'll make a follow up PR removing the
msw2
alias throughout the app.