Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup remaining MSW V1 things #3365

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR cleans up the remainder of things using MSW V1, once merged I'll make a follow up PR removing the msw2 alias throughout the app.

Copy link

codecov-public-qa bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (55c3e63) to head (c355f27).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3365   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14105    14105           
  Branches     3886     3891    +5     
=======================================
  Hits        13988    13988           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.95% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c3e63...c355f27. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (55c3e63) to head (c355f27).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3365   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14105    14105           
  Branches     3886     3886           
=======================================
  Hits        13988    13988           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.95% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c3e63...c355f27. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3365   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14105    14105           
  Branches     3891     3886    -5     
=======================================
  Hits        13988    13988           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.95% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c3e63...c355f27. Read the comment docs.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (55c3e63) to head (c355f27).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3365   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         799      799           
  Lines       14105    14105           
  Branches     3891     3886    -5     
=======================================
  Hits        13988    13988           
  Misses        108      108           
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.95% <ø> (ø)
Services 99.44% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c3e63...c355f27. Read the comment docs.

Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Oct 8, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
c355f27 Tue, 08 Oct 2024 16:58:14 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 01a7a7c Oct 9, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-cleanup-remaining-msw-v1 branch October 9, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants