[fix] Relocate the upload widget to the bottom on small screens #3348
Conversation
rohitvinnakota-codecov
force-pushed
the
rvinnakota/update-layout-mobile
branch
from
03c758b to
66501a8
Compare
rohitvinnakota-codecov
force-pushed
the
rvinnakota/update-layout-mobile
branch
from
66501a8 to
1b0a53a
Compare
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will decrease total bundle size by 57 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3348 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 797 797
Lines 13877 13877
Branches 3817 3822 +5
=======================================
Hits 13756 13756
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 57 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3348 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 797 797
Lines 13877 13877
Branches 3822 3817 -5
=======================================
Hits 13756 13756
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 797 797
Lines 13877 13877
Branches 3817 3822 +5
=======================================
Hits 13756 13756
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3348 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 797 797
Lines 13877 13877
Branches 3817 3817
=======================================
Hits 13756 13756
Misses 112 112
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
|
Hrrm just taking a peak at the preview deploy, if there are no errors and we're still showing the upload card below, this could be an issue if there are a lot of files, as this will be pushed down quite far, and not visible to the user, is this something we want? cc @Adal3n3
|
rohitvinnakota-codecov
changed the title
|
@nicholas-codecov @rohitvinnakota-codecov @Adal3n3 We plan to hide this behind a toggle in an upcoming ticket. I'd argue it should stay at the top with all of this in mind. |
|
Discussed offline. Proceeding for now. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
This closes codecov/engineering-team#2499.
Before
After
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.