Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ui/SettingsDescriptor to Vitest #3241

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the ui/SettingsDescriptor to TS and tests to Vitest

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 71 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.0MB 71 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 23, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ac97cdf Mon, 23 Sep 2024 11:08:18 GMT Expired Expired
1548cf7 Tue, 24 Sep 2024 23:47:38 GMT Cloud Enterprise

Copy link
Contributor

@calvin-codecov calvin-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Are the new files too different for github to keep thinking it's a filename change instead of a delete/add?

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (0ea9588) to head (1548cf7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3241   +/-   ##
===========================================
  Coverage   98.98000   98.98000           
===========================================
  Files           805        805           
  Lines         14035      14034    -1     
  Branches       3911       3964   +53     
===========================================
- Hits          13892      13891    -1     
  Misses          134        134           
  Partials          9          9           
Files with missing lines Coverage Δ
src/ui/SettingsDescriptor/SettingsDescriptor.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9588...1548cf7. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (0ea9588) to head (1548cf7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   98.98%   98.98%   -0.01%     
==========================================
  Files         805      805              
  Lines       14035    14034       -1     
  Branches     3990     3990              
==========================================
- Hits        13892    13891       -1     
  Misses        134      134              
  Partials        9        9              
Files with missing lines Coverage Δ
src/ui/SettingsDescriptor/SettingsDescriptor.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9588...1548cf7. Read the comment docs.

@nicholas-codecov
Copy link
Contributor Author

LGTM

Are the new files too different for github to keep thinking it's a filename change instead of a delete/add?

Ahh that, and there are some decent changes between the JS and the TS versions but no logically difference

Copy link

codecov bot commented Sep 24, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov-public-qa bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (0ea9588) to head (1548cf7).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   98.98%   98.98%   -0.01%     
==========================================
  Files         805      805              
  Lines       14035    14034       -1     
  Branches     3911     3964      +53     
==========================================
- Hits        13892    13891       -1     
  Misses        134      134              
  Partials        9        9              
Files Coverage Δ
src/ui/SettingsDescriptor/SettingsDescriptor.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9588...1548cf7. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   98.98%   98.98%   -0.01%     
==========================================
  Files         805      805              
  Lines       14035    14034       -1     
  Branches     3990     3990              
==========================================
- Hits        13892    13891       -1     
  Misses        134      134              
  Partials        9        9              
Files with missing lines Coverage Δ
src/ui/SettingsDescriptor/SettingsDescriptor.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.49% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.65% <ø> (ø)
UI 99.18% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea9588...1548cf7. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 0a05c2d Sep 24, 2024
64 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-update-ui-settings-descriptor-to-vitest branch September 24, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants