-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update ui/SettingsDescriptor to Vitest #3241
chore: Update ui/SettingsDescriptor to Vitest #3241
Conversation
Bundle ReportChanges will increase total bundle size by 71 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are the new files too different for github to keep thinking it's a filename change instead of a delete/add?
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
===========================================
Coverage 98.98000 98.98000
===========================================
Files 805 805
Lines 14035 14034 -1
Branches 3911 3964 +53
===========================================
- Hits 13892 13891 -1
Misses 134 134
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 805 805
Lines 14035 14034 -1
Branches 3990 3990
==========================================
- Hits 13892 13891 -1
Misses 134 134
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Ahh that, and there are some decent changes between the JS and the TS versions but no logically difference |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 805 805
Lines 14035 14034 -1
Branches 3911 3964 +53
==========================================
- Hits 13892 13891 -1
Misses 134 134
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 98.98% 98.98% -0.01%
==========================================
Files 805 805
Lines 14035 14034 -1
Branches 3990 3990
==========================================
- Hits 13892 13891 -1
Misses 134 134
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Description
This PR updates the
ui/SettingsDescriptor
to TS and tests to Vitest