Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useRepoCoverageTimeseries using wrong field #3190

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Sep 12, 2024

Description

Small fix to the useRepoCoverageTimeseries hook as it's using the incorrect field, causing it to not re-run when a user selects a different trend. 🤦

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 4 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.0MB 4 bytes ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (b137fd5) to head (837b120).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3190   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         935      935           
  Lines       14510    14510           
  Branches     3886     3968   +82     
=======================================
  Hits        14240    14240           
  Misses        265      265           
  Partials        5        5           
Files with missing lines Coverage Δ
...Tab/OverviewTab/hooks/useRepoCoverageTimeseries.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b137fd5...837b120. Read the comment docs.

Copy link

codecov bot commented Sep 12, 2024

Bundle Report

Changes will decrease total bundle size by 4 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.0MB 4 bytes ⬇️

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (b137fd5) to head (837b120).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3190   +/-   ##
===========================================
  Coverage   98.13000   98.13000           
===========================================
  Files           935        935           
  Lines         14510      14510           
  Branches       3886       3973   +87     
===========================================
  Hits          14240      14240           
  Misses          265        265           
  Partials          5          5           
Files with missing lines Coverage Δ
...Tab/OverviewTab/hooks/useRepoCoverageTimeseries.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b137fd5...837b120. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3190   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         935      935           
  Lines       14510    14510           
  Branches     3968     3941   -27     
=======================================
  Hits        14240    14240           
  Misses        265      265           
  Partials        5        5           
Files Coverage Δ
...Tab/OverviewTab/hooks/useRepoCoverageTimeseries.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b137fd5...837b120. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (b137fd5) to head (837b120).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3190   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         935      935           
  Lines       14510    14510           
  Branches     3941     3941           
=======================================
  Hits        14240    14240           
  Misses        265      265           
  Partials        5        5           
Files Coverage Δ
...Tab/OverviewTab/hooks/useRepoCoverageTimeseries.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 98.84% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b137fd5...837b120. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 12, 2024
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
837b120 Thu, 12 Sep 2024 10:30:54 GMT Cloud Enterprise

Merged via the queue into main with commit 3c1be0d Sep 12, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-accessing-incorrect-field-on-object-to-fix-coverage-chart branch September 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants