chore: Clean up from 2489 #3180

nicholas-codecov · 2024-09-10T18:00:22Z

Description

This PR contains some clean up from codecov/engineering-team#2489, such as removing/replacing useBundleAssets with usePagedBundleAssets, and introducing a global OrderingDirection type.

Notable Changes

Create new OrderingDirection type on global types file and associated config tweaks to add this import alias into the codebase
- Update use cases of 'ASC' | 'DESC' and 'DESC' | 'ASC'
Remove old useBundleAssets and rename usePagedBundleAssets to previous useBundleAssets
Update tests

codecov-staging · 2024-09-10T18:02:53Z

Bundle Report

Changes will decrease total bundle size by 843 bytes ⬇️

Bundle name	Size	Change
gazebo-staging-array-push	6.0MB	843 bytes ⬇️

codecov-qa · 2024-09-10T18:03:24Z

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.24%. Comparing base (ca2b681) to head (9239ab0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/services/bundleAnalysis/useBundleAssets.tsx	93.33%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         936      935       -1     
  Lines       14528    14491      -37     
  Branches     3965     3871      -94     
==========================================
- Hits        14273    14236      -37     
  Misses        250      250              
  Partials        5        5

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <ø> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
src/services/pulls/usePulls.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoComponents.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoFlags.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`97.36% <93.33%> (-2.64%)`	⬇️

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <100.00%> (ø)`
Services	`99.41% <93.33%> (-0.01%)`	⬇️
Shared	`99.50% <ø> (ø)`
UI	`94.67% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2b681...9239ab0. Read the comment docs.

codecov-notifications · 2024-09-10T18:03:40Z

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files	Patch %	Lines
src/services/bundleAnalysis/useBundleAssets.tsx	93.33%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         936      935       -1     
  Lines       14528    14491      -37     
  Branches     3970     3871      -99     
==========================================
- Hits        14273    14236      -37     
  Misses        250      250              
  Partials        5        5

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <ø> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
src/services/pulls/usePulls.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoComponents.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoFlags.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`97.36% <93.33%> (-2.64%)`	⬇️

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <100.00%> (ø)`
Services	`99.41% <93.33%> (-0.01%)`	⬇️
Shared	`99.50% <ø> (ø)`
UI	`94.67% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2b681...9239ab0. Read the comment docs.

codecov-public-qa · 2024-09-10T18:04:01Z

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.24%. Comparing base (ca2b681) to head (9239ab0).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         936      935       -1     
  Lines       14528    14491      -37     
  Branches     3970     3954      -16     
==========================================
- Hits        14273    14236      -37     
  Misses        250      250              
  Partials        5        5

Files	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <ø> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
src/services/pulls/usePulls.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoComponents.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoFlags.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`97.36% <93.33%> (-2.64%)`	⬇️

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <100.00%> (ø)`
Services	`99.41% <93.33%> (-0.01%)`	⬇️
Shared	`99.50% <ø> (ø)`
UI	`94.67% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2b681...9239ab0. Read the comment docs.

codecov · 2024-09-10T18:05:09Z

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.24%. Comparing base (ca2b681) to head (9239ab0).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/services/bundleAnalysis/useBundleAssets.tsx	93.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##               main      #3180   +/-   ##
===========================================
  Coverage   98.24000   98.24000           
===========================================
  Files           936        935    -1     
  Lines         14528      14491   -37     
  Branches       3965       3959    -6     
===========================================
- Hits          14273      14236   -37     
  Misses          250        250           
  Partials          5          5

Files with missing lines	Coverage Δ
...ndlesTab/BundleContent/AssetsTable/AssetsTable.tsx	`100.00% <ø> (ø)`
.../BundleContent/AssetsTable/useBundleAssetsTable.ts	`100.00% <100.00%> (ø)`
src/services/commit/useCommit.tsx	`100.00% <ø> (ø)`
src/services/pathContents/constants.ts	`100.00% <ø> (ø)`
src/services/pulls/usePulls.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoComponents.tsx	`100.00% <ø> (ø)`
src/services/repo/useRepoFlags.tsx	`100.00% <ø> (ø)`
src/services/bundleAnalysis/useBundleAssets.tsx	`97.36% <93.33%> (-2.64%)`	⬇️

Components	Coverage Δ
Assets	`53.48% <ø> (ø)`
Layouts	`98.87% <ø> (ø)`
Pages	`99.03% <100.00%> (ø)`
Services	`99.41% <93.33%> (-0.01%)`	⬇️
Shared	`99.50% <ø> (ø)`
UI	`94.67% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2b681...9239ab0. Read the comment docs.

codecov · 2024-09-10T18:05:12Z

Bundle Report

Changes will decrease total bundle size by 843 bytes (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-array-push	6.0MB	843 bytes ⬇️

codecov-releaser · 2024-09-10T18:07:14Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`9239ab0`	Tue, 10 Sep 2024 18:07:13 GMT	Cloud	Enterprise

spalmurray-codecov · 2024-09-10T18:16:32Z

src/types.ts

spalmurray-codecov

NICE

nicholas-codecov added 4 commits September 10, 2024 14:43

rename usePagedBundleAssets just to useBundleAssets

b02d08c

update affected things and tests

9bcdb3a

add in global types file

c19c5c0

update types to use new ordering direction global type

9239ab0

spalmurray-codecov reviewed Sep 10, 2024

View reviewed changes

src/types.ts

Copy link

Contributor

spalmurray-codecov Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

spalmurray-codecov approved these changes Sep 10, 2024

View reviewed changes

nicholas-codecov added this pull request to the merge queue Sep 10, 2024

Merged via the queue into main with commit 6b9e281 Sep 10, 2024
54 of 62 checks passed

nicholas-codecov deleted the chore-gh-eng-2489-cleanup branch September 10, 2024 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Clean up from 2489 #3180

chore: Clean up from 2489 #3180

nicholas-codecov commented Sep 10, 2024

codecov-staging bot commented Sep 10, 2024

codecov-qa bot commented Sep 10, 2024 •

edited

Loading

codecov-notifications bot commented Sep 10, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 10, 2024

codecov bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024

codecov-releaser commented Sep 10, 2024

spalmurray-codecov Sep 10, 2024

spalmurray-codecov left a comment

chore: Clean up from 2489 #3180

chore: Clean up from 2489 #3180

Conversation

nicholas-codecov commented Sep 10, 2024

Description

Notable Changes

codecov-staging bot commented Sep 10, 2024

Bundle Report

codecov-qa bot commented Sep 10, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Sep 10, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Sep 10, 2024

Codecov Report

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 10, 2024

Bundle Report

codecov-releaser commented Sep 10, 2024

✅ Deploy preview for gazebo ready!

spalmurray-codecov Sep 10, 2024

Choose a reason for hiding this comment

spalmurray-codecov left a comment

Choose a reason for hiding this comment

codecov-qa bot commented Sep 10, 2024 •

edited

Loading

codecov-notifications bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading