Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add in new hook to fetch paginated bundle assets #3176

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat: Add in new hook to fetch paginated bundle assets #3176

merged 2 commits into from
Sep 10, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new hook that fetches a paginated list of assets so that we don't need to fetch them all at once, which should help the load times once utilized with the assets table.

codecov/engineering-team#2489

Notable Changes

  • Create new usePagedBundleAssets hook
  • Create tests

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 5.99MB 0 bytes

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024

Bundle Report

Bundle size has no change ✅

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.25%. Comparing base (6361740) to head (97ffb87).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3176        +/-   ##
================================================
+ Coverage   98.24000   98.25000   +0.01000     
================================================
  Files           935        936         +1     
  Lines         14491      14528        +37     
  Branches       3950       3879        -71     
================================================
+ Hits          14237      14274        +37     
  Misses          249        249                
  Partials          5          5
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% <97.29%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.45% <97.29%> (+<0.01%) ⬆️
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6361740...97ffb87. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.25%. Comparing base (6361740) to head (97ffb87).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3176   +/-   ##
=======================================
  Coverage   98.24%   98.25%           
=======================================
  Files         935      936    +1     
  Lines       14491    14528   +37     
  Branches     3868     3961   +93     
=======================================
+ Hits        14237    14274   +37     
  Misses        249      249           
  Partials        5        5
Files Coverage Δ
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% <97.29%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.45% <97.29%> (+<0.01%) ⬆️
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6361740...97ffb87. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3176   +/-   ##
=======================================
  Coverage   98.24%   98.25%           
=======================================
  Files         935      936    +1     
  Lines       14491    14528   +37     
  Branches     3950     3966   +16     
=======================================
+ Hits        14237    14274   +37     
  Misses        249      249           
  Partials        5        5
Files Coverage Δ
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% <97.29%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.45% <97.29%> (+<0.01%) ⬆️
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6361740...97ffb87. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.25%. Comparing base (6361740) to head (97ffb87).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3176   +/-   ##
=======================================
  Coverage   98.24%   98.25%           
=======================================
  Files         935      936    +1     
  Lines       14491    14528   +37     
  Branches     3868     3961   +93     
=======================================
+ Hits        14237    14274   +37     
  Misses        249      249           
  Partials        5        5
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/usePagedBundleAssets.tsx 97.29% <97.29%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.45% <97.29%> (+<0.01%) ⬆️
Shared 99.50% <ø> (ø)
UI 94.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6361740...97ffb87. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
97ffb87 Tue, 10 Sep 2024 12:57:01 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit d6068de Sep 10, 2024
54 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2489-paginate-bundle-assets-create-hook branch September 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov