Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Await the imports after enabling prism #3168

Merged
merged 6 commits into from
Sep 6, 2024
Merged

fix: Await the imports after enabling prism #3168

merged 6 commits into from
Sep 6, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This is an attempt at resolving issues with importing third party prism language highlighting packs.

@codecov-staging
Copy link

codecov-staging bot commented Sep 6, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 510 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.99MB 510 bytes ⬇️

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.18kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.99MB 2.18kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 6, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
11012d9 Fri, 06 Sep 2024 17:57:17 GMT Expired Expired
37d8fb9 Fri, 06 Sep 2024 18:25:20 GMT Expired Expired
37d8fb9 Fri, 06 Sep 2024 18:29:43 GMT Expired Expired
b2f789c Fri, 06 Sep 2024 18:40:32 GMT Cloud Enterprise

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (b2f789c).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      934       +1     
  Lines       14458    14462       +4     
  Branches     3949     3950       +1     
==========================================
+ Hits        14205    14208       +3     
- Misses        248      249       +1     
  Partials        5        5
Files Coverage Δ
src/shared/utils/prism/prismLanguageMapper.ts 100.00% <100.00%> (ø)
src/shared/utils/prism/prismLanguages.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (+<0.01%) ⬆️
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.50% <100.00%> (-0.01%) ⬇️
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...b2f789c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (b2f789c).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      934       +1     
  Lines       14458    14462       +4     
  Branches     3944     3955      +11     
==========================================
+ Hits        14205    14208       +3     
- Misses        248      249       +1     
  Partials        5        5
Files with missing lines Coverage Δ
src/shared/utils/prism/prismLanguageMapper.ts 100.00% <100.00%> (ø)
src/shared/utils/prism/prismLanguages.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (+<0.01%) ⬆️
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.50% <100.00%> (-0.01%) ⬇️
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...b2f789c. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3168      +/-   ##
==========================================
- Coverage   98.25%   98.24%   -0.01%     
==========================================
  Files         933      934       +1     
  Lines       14458    14462       +4     
  Branches     3944     3950       +6     
==========================================
+ Hits        14205    14208       +3     
- Misses        248      249       +1     
  Partials        5        5
Files Coverage Δ
src/shared/utils/prism/prismLanguageMapper.ts 100.00% <100.00%> (ø)
src/shared/utils/prism/prismLanguages.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (+<0.01%) ⬆️
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.50% <100.00%> (-0.01%) ⬇️
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...b2f789c. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e6a4224) to head (b2f789c).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3168        +/-   ##
================================================
- Coverage   98.25000   98.24000   -0.01000     
================================================
  Files           933        934         +1     
  Lines         14458      14462         +4     
  Branches       3944       3950         +6     
================================================
+ Hits          14205      14208         +3     
- Misses          248        249         +1     
  Partials          5          5
Files with missing lines Coverage Δ
src/shared/utils/prism/prismLanguageMapper.ts 100.00% <100.00%> (ø)
src/shared/utils/prism/prismLanguages.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (+<0.01%) ⬆️
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.50% <100.00%> (-0.01%) ⬇️
UI 94.60% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a4224...b2f789c. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit c23cecf Sep 6, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-await-the-imports-after-enabling-prism branch September 6, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @ajay-sentry