feat: Add bundle analysis feedback survey banner #3135
Conversation
| @@ -765,17 +765,6 @@ export function useNavLinks() { | |||
| ) => `/${provider}/${owner}/${repo}/bundles/new/webpack`, | |||
| text: 'Webpack', | |||
| }, | |||
| teamPlanFeedbackSurvey: { | |||
There was a problem hiding this comment.
accidentally left in last PR
| )} | ||
| > | ||
| {children} | ||
| <div> |
There was a problem hiding this comment.
wrapper div is necessary so the css in parent cannot mess with the flex display here
Bundle ReportChanges will increase total bundle size by 3.8kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3135 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 918 919 +1
Lines 14168 14177 +9
Branches 3918 3895 -23
=======================================
+ Hits 13929 13938 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3135 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 918 919 +1
Lines 14168 14177 +9
Branches 3923 3921 -2
=======================================
+ Hits 13929 13938 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3135 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 918 919 +1
Lines 14168 14177 +9
Branches 3837 3895 +58
=======================================
+ Hits 13929 13938 +9
Misses 234 234
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3135 +/- ##
================================================
+ Coverage 0.00000 98.31000 +98.31000
================================================
Files 0 919 +919
Lines 0 14177 +14177
Branches 0 3921 +3921
================================================
+ Hits 0 13938 +13938
- Misses 0 234 +234
- Partials 0 5 +5
... and 913 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Adds bundle analysis feedback survey banner. Also, adjusts GlobalTopBanners to only render at most one banner. Was scratching my head for a bit on how to only show max one banner, but just had to use my whole brain and realize could do with CSS 😄
Design
Closes codecov/engineering-team#2030