Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle activation alert in failed tests page #3133

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Aug 16, 2024

Description

As we roll out new features such as bundle and failed tests and when they become part of a paid plan, these areas should have the same conditional trial offering and/or upgrade UX. This means if the plan is private/unpaid and/or seats not activate the same communication is made across the features.

This PR renders activation alert in failed tests page when user is not activated and current repo is private

Notable Changes

  • Removed the unnecessary owner not activated union type
  • Added is current user activated field to repo overview
  • Fixed tests
  • Actually rendered the activation alert in the failed tests tab

Screenshots

Screenshot 2024-08-16 at 2 21 35 PM

issue: codecov/engineering-team#1689

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Aug 16, 2024

Bundle Report

Changes will increase total bundle size by 47 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.71MB 47 bytes ⬆️

Copy link

codecov-public-qa bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3855     3932      +77     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5              
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) ⬆️
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.44% <ø> (-0.07%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3941     3851      -90     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5              
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) ⬆️
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.44% <ø> (-0.07%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
- Coverage   98.31%   98.29%   -0.02%     
==========================================
  Files         923      923              
  Lines       14400    14393       -7     
  Branches     3910     3937      +27     
==========================================
- Hits        14157    14148       -9     
- Misses        238      240       +2     
  Partials        5        5              
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) ⬆️
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.44% <ø> (-0.07%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Aug 16, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
6980230 Fri, 16 Aug 2024 12:18:24 GMT Expired Expired
72fd86f Wed, 28 Aug 2024 09:13:07 GMT Cloud Enterprise

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (703b34b) to head (72fd86f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3133        +/-   ##
================================================
- Coverage   98.31000   98.29000   -0.02000     
================================================
  Files           923        923                
  Lines         14400      14393         -7     
  Branches       3910       3932        +22     
================================================
- Hits          14157      14148         -9     
- Misses          238        240         +2     
  Partials          5          5                
Files Coverage Δ
...c/pages/RepoPage/FailedTestsTab/FailedTestsTab.tsx 93.33% <100.00%> (+1.02%) ⬆️
src/pages/RepoPage/RepoPage.tsx 100.00% <100.00%> (ø)
src/pages/RepoPage/RepoPageTabs.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoOverview.tsx 96.66% <ø> (-3.34%) ⬇️

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <100.00%> (-0.01%) ⬇️
Services 99.44% <ø> (-0.07%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.51% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703b34b...72fd86f. Read the comment docs.

@RulaKhaled RulaKhaled added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 47 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.71MB 47 bytes ⬆️

@RulaKhaled RulaKhaled enabled auto-merge August 27, 2024 11:02
@RulaKhaled RulaKhaled added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit e1e65bb Aug 28, 2024
58 of 62 checks passed
@RulaKhaled RulaKhaled deleted the activation-status branch August 28, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants