-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Memoize Highlight so it does not re-render on line click #3123
fix: Memoize Highlight so it does not re-render on line click #3123
Conversation
…te the URL with the line hash
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3123 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 917 917
Lines 14149 14151 +2
Branches 3923 3918 -5
=======================================
+ Hits 13908 13910 +2
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3123 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 917 917
Lines 14149 14151 +2
Branches 3893 3893
=======================================
+ Hits 13908 13910 +2
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3123 +/- ##
=======================================
Coverage 98.29% 98.29%
=======================================
Files 917 917
Lines 14149 14151 +2
Branches 3918 3893 -25
=======================================
+ Hits 13908 13910 +2
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Bundle ReportChanges will increase total bundle size by 164 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
===========================================
Coverage 98.29000 98.29000
===========================================
Files 917 917
Lines 14149 14151 +2
Branches 3923 3923
===========================================
+ Hits 13908 13910 +2
Misses 236 236
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Description
Small tweak to the virtual file renderer so that it doesn't re-tokenize and slow down the highlight process. This happens because the parent component (raw file viewer) also access the router location so it renders because the router context is updated.
Notable Changes
Highlight
component