Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update yarn version and align pinned nvm node #3116

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Updates yarn to 4.4.0 and brings pinned node version in .nvmrc in line with pinned version in volta.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Aug 12, 2024

Bundle Report

Changes will increase total bundle size by 2.16kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.84MB 2.16kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Aug 12, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a816a2c Mon, 12 Aug 2024 15:25:21 GMT Expired Expired
440cdfd Mon, 12 Aug 2024 15:35:04 GMT Expired Expired
440cdfd Mon, 12 Aug 2024 15:39:47 GMT Cloud Enterprise

Copy link

codecov-public-qa bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (440cdfd).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3116   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14126   +11     
  Branches     3859     3814   -45     
=======================================
+ Hits        13875    13886   +11     
  Misses        235      235           
  Partials        5        5           

see 5 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (+0.29%) ⬆️
Pages 99.02% <ø> (+<0.01%) ⬆️
Services 99.47% <ø> (-0.04%) ⬇️
Shared 99.69% <ø> (ø)
UI 94.57% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...440cdfd. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (440cdfd).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3116   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14126   +11     
  Branches     3859     3898   +39     
=======================================
+ Hits        13875    13886   +11     
  Misses        235      235           
  Partials        5        5           

see 5 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (+0.29%) ⬆️
Pages 99.02% <ø> (+<0.01%) ⬆️
Services 99.47% <ø> (-0.04%) ⬇️
Shared 99.69% <ø> (ø)
UI 94.57% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...440cdfd. Read the comment docs.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (440cdfd).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3116        +/-   ##
================================================
+ Coverage   98.29000   98.30000   +0.01000     
================================================
  Files           918        918                
  Lines         14115      14126        +11     
  Branches       3889       3893         +4     
================================================
+ Hits          13875      13886        +11     
  Misses          235        235                
  Partials          5          5                

see 5 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (+0.29%) ⬆️
Pages 99.02% <ø> (+<0.01%) ⬆️
Services 99.47% <ø> (-0.04%) ⬇️
Shared 99.69% <ø> (ø)
UI 94.57% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...440cdfd. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3116   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14126   +11     
  Branches     3805     3868   +63     
=======================================
+ Hits        13875    13886   +11     
  Misses        235      235           
  Partials        5        5           

see 5 files with indirect coverage changes

Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (+0.29%) ⬆️
Pages 99.02% <ø> (+<0.01%) ⬆️
Services 99.47% <ø> (-0.04%) ⬇️
Shared 99.69% <ø> (ø)
UI 94.57% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...440cdfd. Read the comment docs.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review August 12, 2024 15:29
Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! have a quick non-blocking question to ajay in above!

package.json Show resolved Hide resolved
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 5c81454 Aug 12, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/versions-asdf branch August 12, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants