Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Convert BaseLayout to TS #3114

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

spalmurray-codecov
Copy link
Contributor

Converts BaseLayout.jsx to BaseLayout.tsx. Also shows normal header when impersonating and not isFullExperience.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review August 9, 2024 19:42
@codecov-qa
Copy link

codecov-qa bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (908510f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3114   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14114    -1     
  Branches     3859     3859           
=======================================
  Hits        13875    13875           
+ Misses        235      234    -1     
  Partials        5        5           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <100.00%> (+0.29%) ⬆️
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...908510f. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (908510f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3114   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14114    -1     
  Branches     3859     3884   +25     
=======================================
  Hits        13875    13875           
+ Misses        235      234    -1     
  Partials        5        5           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <100.00%> (+0.29%) ⬆️
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...908510f. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3114   +/-   ##
=======================================
  Coverage   98.29%   98.30%           
=======================================
  Files         918      918           
  Lines       14115    14114    -1     
  Branches     3805     3884   +79     
=======================================
  Hits        13875    13875           
+ Misses        235      234    -1     
  Partials        5        5           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <100.00%> (+0.29%) ⬆️
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...908510f. Read the comment docs.

Copy link

codecov bot commented Aug 9, 2024

Bundle Report

Changes will increase total bundle size by 198 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.84MB 198 bytes ⬆️

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (6b69c4d) to head (908510f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3114        +/-   ##
================================================
+ Coverage   98.29000   98.30000   +0.01000     
================================================
  Files           918        918                
  Lines         14115      14114         -1     
  Branches       3889       3884         -5     
================================================
  Hits          13875      13875                
+ Misses          235        234         -1     
  Partials          5          5                
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <100.00%> (+0.29%) ⬆️
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b69c4d...908510f. Read the comment docs.

@@ -70,7 +82,7 @@ function BaseLayout({ children }) {
<>
<Suspense fallback={<FullPageLoader />}>
<RepoBreadcrumbProvider>
{isFullExperience ? (
{isFullExperience || isImpersonating ? (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to prevent the weird case when impersonating someone who has not completed onboarding

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
908510f Fri, 09 Aug 2024 19:44:57 GMT Cloud Enterprise

Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit cb034a3 Aug 12, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/convert-baselayout branch August 12, 2024 13:30
Copy link

sentry-io bot commented Aug 14, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/tree/:branch/:path+ View Issue
  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/pull/:pullId/components View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants