-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Convert BaseLayout to TS #3114
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3114 +/- ##
=======================================
Coverage 98.29% 98.30%
=======================================
Files 918 918
Lines 14115 14114 -1
Branches 3859 3859
=======================================
Hits 13875 13875
+ Misses 235 234 -1
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3114 +/- ##
=======================================
Coverage 98.29% 98.30%
=======================================
Files 918 918
Lines 14115 14114 -1
Branches 3859 3884 +25
=======================================
Hits 13875 13875
+ Misses 235 234 -1
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3114 +/- ##
=======================================
Coverage 98.29% 98.30%
=======================================
Files 918 918
Lines 14115 14114 -1
Branches 3805 3884 +79
=======================================
Hits 13875 13875
+ Misses 235 234 -1
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 198 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
================================================
+ Coverage 98.29000 98.30000 +0.01000
================================================
Files 918 918
Lines 14115 14114 -1
Branches 3889 3884 -5
================================================
Hits 13875 13875
+ Misses 235 234 -1
Partials 5 5
Continue to review full report in Codecov by Sentry.
|
@@ -70,7 +82,7 @@ function BaseLayout({ children }) { | |||
<> | |||
<Suspense fallback={<FullPageLoader />}> | |||
<RepoBreadcrumbProvider> | |||
{isFullExperience ? ( | |||
{isFullExperience || isImpersonating ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to prevent the weird case when impersonating someone who has not completed onboarding
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Converts BaseLayout.jsx to BaseLayout.tsx. Also shows normal header when impersonating and not isFullExperience.