Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File explorer sticky top bar in wrong location #3105

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Aug 8, 2024

Fixes the file explorer top bar sticking in the wrong place:

Screenshot 2024-08-08 at 11 25 49

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review August 8, 2024 15:26
@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Aug 8, 2024

Bundle Report

Changes will decrease total bundle size by 77 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 5.85MB 77 bytes ⬇️

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-qa
Copy link

codecov-qa bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (4aea1da) to head (986211f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3105   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         917      917           
  Lines       13999    13999           
  Branches     3848     3823   -25     
=======================================
  Hits        13754    13754           
  Misses        240      240           
  Partials        5        5           
Files Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
src/ui/FileViewer/ToggleHeader/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 97.32% <ø> (ø)
Pages 99.02% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.11% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea1da...986211f. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (4aea1da) to head (986211f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3105   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         917      917           
  Lines       13999    13999           
  Branches     3848     3769   -79     
=======================================
  Hits        13754    13754           
  Misses        240      240           
  Partials        5        5           
Files Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
src/ui/FileViewer/ToggleHeader/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 97.32% <ø> (ø)
Pages 99.02% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.11% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea1da...986211f. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3105   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         917      917           
  Lines       13999    13999           
  Branches     3853     3769   -84     
=======================================
  Hits        13754    13754           
  Misses        240      240           
  Partials        5        5           
Files Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
src/ui/FileViewer/ToggleHeader/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 97.32% <ø> (ø)
Pages 99.02% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.11% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea1da...986211f. Read the comment docs.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (4aea1da) to head (986211f).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3105   +/-   ##
===========================================
  Coverage   98.24000   98.24000           
===========================================
  Files           917        917           
  Lines         13999      13999           
  Branches       3848       3769   -79     
===========================================
  Hits          13754      13754           
  Misses          240        240           
  Partials          5          5           
Files Coverage Δ
...OverviewTab/subroute/FileExplorer/FileExplorer.jsx 100.00% <ø> (ø)
src/ui/FileViewer/ToggleHeader/Title/Title.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 97.32% <ø> (ø)
Pages 99.02% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.11% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea1da...986211f. Read the comment docs.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 5bb25d6 Aug 8, 2024
60 of 61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-fileviewer-sticky-header branch August 8, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants