-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avatars not loading for github provider #3075
Conversation
Bundle ReportChanges will increase total bundle size by 324 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 324 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3075 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 928 928
Lines 13906 13906
Branches 3787 3763 -24
=======================================
Hits 13666 13666
Misses 236 236
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3075 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 928 928
Lines 13906 13906
Branches 3710 3787 +77
=======================================
Hits 13666 13666
Misses 236 236
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3075 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 928 928
Lines 13906 13906
Branches 3710 3763 +53
=======================================
Hits 13666 13666
Misses 236 236
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
===========================================
Coverage 98.27000 98.27000
===========================================
Files 928 928
Lines 13906 13906
Branches 3787 3763 -24
===========================================
Hits 13666 13666
Misses 236 236
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Noticed this issue seems to be happening quite a bit, so I tested locally and found that we don't have a url mapper for the 'github' provider, only for 'gh'. This PR adds a mapper for 'github'.