Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avatars not loading for github provider #3075

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jul 29, 2024

Noticed this issue seems to be happening quite a bit, so I tested locally and found that we don't have a url mapper for the 'github' provider, only for 'gh'. This PR adds a mapper for 'github'.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 29, 2024 18:01
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 324 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.84MB 324 bytes ⬆️

Copy link

codecov bot commented Jul 29, 2024

Bundle Report

Changes will increase total bundle size by 324 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.84MB 324 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (ae2d9f5) to head (edab9f4).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3075   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         928      928           
  Lines       13906    13906           
  Branches     3787     3763   -24     
=======================================
  Hits        13666    13666           
  Misses        236      236           
  Partials        4        4           
Files Coverage Δ
src/shared/utils/ownerHelpers.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.75% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2d9f5...edab9f4. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (ae2d9f5) to head (edab9f4).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3075   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         928      928           
  Lines       13906    13906           
  Branches     3710     3787   +77     
=======================================
  Hits        13666    13666           
  Misses        236      236           
  Partials        4        4           
Files Coverage Δ
src/shared/utils/ownerHelpers.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.75% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2d9f5...edab9f4. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3075   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         928      928           
  Lines       13906    13906           
  Branches     3710     3763   +53     
=======================================
  Hits        13666    13666           
  Misses        236      236           
  Partials        4        4           
Files Coverage Δ
src/shared/utils/ownerHelpers.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.75% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2d9f5...edab9f4. Read the comment docs.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (ae2d9f5) to head (edab9f4).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3075   +/-   ##
===========================================
  Coverage   98.27000   98.27000           
===========================================
  Files           928        928           
  Lines         13906      13906           
  Branches       3787       3763   -24     
===========================================
  Hits          13666      13666           
  Misses          236        236           
  Partials          4          4           
Files Coverage Δ
src/shared/utils/ownerHelpers.js 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.75% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae2d9f5...edab9f4. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
edab9f4 Mon, 29 Jul 2024 18:07:46 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit 20a2abf Jul 29, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-avatar-images-github branch July 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants