-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: update date-fns to latest #3067
Conversation
Bundle ReportChanges will decrease total bundle size by 54.31kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 54.31kB ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3067 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 925 925
Lines 13772 13772
Branches 3742 3662 -80
=======================================
Hits 13503 13503
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3067 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 925 925
Lines 13772 13772
Branches 3737 3742 +5
=======================================
Hits 13503 13503
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3067 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 925 925
Lines 13772 13772
Branches 3737 3662 -75
=======================================
Hits 13503 13503
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
===========================================
Coverage 98.04000 98.04000
===========================================
Files 925 925
Lines 13772 13772
Branches 3662 3737 +75
===========================================
Hits 13503 13503
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Saw our date-fns and date-fns-tz libraries were out of date, and the latest date-fns library is actually much smaller than the version we were using
Checking the breaking changes, nothing too crazy on our end since we were already destructuring our imports from the library. Just had to fix a couple date-fns-tz imported functions to their new name
We should also maybe look into swapping to dayjs since it's quite a bit smaller, and we're not really using dates all that much throughout the app. It probably would be ~1 day effort, maybe 2.
bundlephobia
Date-fns releases
Date-fns-tz releases
dayjs for reference
Screenshots
Confirming app still renders dates properly
Screen.Recording.2024-07-26.at.8.32.22.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.