Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: update date-fns to latest #3067

Merged
merged 3 commits into from
Jul 26, 2024
Merged

dev: update date-fns to latest #3067

merged 3 commits into from
Jul 26, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Jul 26, 2024

Description

Saw our date-fns and date-fns-tz libraries were out of date, and the latest date-fns library is actually much smaller than the version we were using

Checking the breaking changes, nothing too crazy on our end since we were already destructuring our imports from the library. Just had to fix a couple date-fns-tz imported functions to their new name

We should also maybe look into swapping to dayjs since it's quite a bit smaller, and we're not really using dates all that much throughout the app. It probably would be ~1 day effort, maybe 2.

bundlephobia

Date-fns releases
Date-fns-tz releases

dayjs for reference

Screenshots

Confirming app still renders dates properly

Screen.Recording.2024-07-26.at.8.32.22.AM.mov

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 54.31kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.8MB 54.31kB ⬇️

Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will decrease total bundle size by 54.31kB ⬇️

Bundle name Size Change
gazebo-production-array-push 5.8MB 54.31kB ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (2b744fe) to head (704379e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3067   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         925      925           
  Lines       13772    13772           
  Branches     3742     3662   -80     
=======================================
  Hits        13503    13503           
  Misses        265      265           
  Partials        4        4           
Files Coverage Δ
...es/InvoiceDetailsPage/sections/InvoiceOverview.tsx 83.33% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b744fe...704379e. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (2b744fe) to head (704379e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3067   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         925      925           
  Lines       13772    13772           
  Branches     3737     3742    +5     
=======================================
  Hits        13503    13503           
  Misses        265      265           
  Partials        4        4           
Files Coverage Δ
...es/InvoiceDetailsPage/sections/InvoiceOverview.tsx 83.33% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b744fe...704379e. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3067   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         925      925           
  Lines       13772    13772           
  Branches     3737     3662   -75     
=======================================
  Hits        13503    13503           
  Misses        265      265           
  Partials        4        4           
Files Coverage Δ
...es/InvoiceDetailsPage/sections/InvoiceOverview.tsx 83.33% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b744fe...704379e. Read the comment docs.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (2b744fe) to head (704379e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3067   +/-   ##
===========================================
  Coverage   98.04000   98.04000           
===========================================
  Files           925        925           
  Lines         13772      13772           
  Branches       3662       3737   +75     
===========================================
  Hits          13503      13503           
  Misses          265        265           
  Partials          4          4           
Files Coverage Δ
...es/InvoiceDetailsPage/sections/InvoiceOverview.tsx 83.33% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b744fe...704379e. Read the comment docs.

@ajay-sentry ajay-sentry added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit e40d38c Jul 26, 2024
61 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/update-date-fns branch July 26, 2024 15:51
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
704379e Fri, 26 Jul 2024 16:11:32 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants