dev: Remove yup and convert to zod #3060
Conversation
Bundle ReportChanges will decrease total bundle size by 32.89kB ⬇️
|
Bundle ReportChanges will decrease total bundle size by 32.89kB ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3060 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 924 924
Lines 13761 13761
Branches 3659 3659
=======================================
Hits 13492 13492
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
===========================================
Coverage 98.04000 98.04000
===========================================
Files 924 924
Lines 13761 13761
Branches 3734 3739 +5
===========================================
Hits 13492 13492
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3060 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 924 924
Lines 13761 13761
Branches 3734 3659 -75
=======================================
Hits 13492 13492
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3060 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 924 924
Lines 13761 13761
Branches 3734 3659 -75
=======================================
Hits 13492 13492
Misses 265 265
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Saw we were using a package called "yup," and was wondering what it was used for. Realized it's basically just zod, and that there was only one usage in the codebase
Looked simple enough to remove and we save 18KB from doing so!
Closes codecov/engineering-team#2153
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.