Feat: Fix Failed Test Table Sort, link Hook, and add Spec #3054
Conversation
Bundle ReportChanges will increase total bundle size by 2.48kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3054 +/- ##
==========================================
+ Coverage 98.04% 98.33% +0.28%
==========================================
Files 924 924
Lines 13761 13784 +23
Branches 3659 3746 +87
==========================================
+ Hits 13492 13554 +62
+ Misses 265 226 -39
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 2.48kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3054 +/- ##
==========================================
+ Coverage 98.04% 98.33% +0.28%
==========================================
Files 924 924
Lines 13761 13784 +23
Branches 3734 3746 +12
==========================================
+ Hits 13492 13554 +62
+ Misses 265 226 -39
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3054 +/- ##
==========================================
+ Coverage 98.04% 98.33% +0.28%
==========================================
Files 924 924
Lines 13761 13784 +23
Branches 3710 3741 +31
==========================================
+ Hits 13492 13554 +62
+ Misses 265 226 -39
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
================================================
+ Coverage 98.04000 98.33000 +0.29000
================================================
Files 924 924
Lines 13761 13784 +23
Branches 3710 3664 -46
================================================
+ Hits 13492 13554 +62
+ Misses 265 226 -39
Partials 4 4
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
changed the title
Description
This PR aims to finalize the failed test table stuff, mainly linking the hook, presenting the information correctly, and adding tests for the table.
We were able to test the infinite scroll works as expected, as well as sorting each column
There is an interesting bug that still needs to be fixed though related to scrolling on initial page load when commitsFailed descending order is the column being sorted on
Screenshots
Screen.Recording.2024-07-25.at.4.12.18.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.