-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add configuration manager tab to repo settings #3040
feat: Add configuration manager tab to repo settings #3040
Conversation
Bundle ReportChanges will increase total bundle size by 533 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13608 13618 +10
Branches 3682 3617 -65
=======================================
+ Hits 13386 13396 +10
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13608 13618 +10
Branches 3610 3617 +7
=======================================
+ Hits 13386 13396 +10
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 533 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3040 +/- ##
===========================================
Coverage 98.36000 98.36000
===========================================
Files 914 914
Lines 13608 13618 +10
Branches 3610 3617 +7
===========================================
+ Hits 13386 13396 +10
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3040 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13608 13618 +10
Branches 3687 3617 -70
=======================================
+ Hits 13386 13396 +10
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
expect( | ||
await screen.findByRole('link', { name: /General/ }) | ||
).toBeInTheDocument() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not gonna ask for any changes, but moving forward can we pull these *By*
out into their own vars and than use the vars in the expects
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Adds the new Configuration Manager tab to the repo settings page (locked behind a feature flag).
Closes codecov/engineering-team#2105