Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration manager tab to repo settings #3040

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Adds the new Configuration Manager tab to the repo settings page (locked behind a feature flag).

Closes codecov/engineering-team#2105

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 19, 2024 19:20
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 533 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.86MB 533 bytes ⬆️

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13608    13618   +10     
  Branches     3682     3617   -65     
=======================================
+ Hits        13386    13396   +10     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/SidebarLayout/SidebarLayout.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/SettingsTab/SettingsTab.tsx 100.00% <100.00%> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.18% <100.00%> (+<0.01%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980d71...d4a4f83. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (d980d71) to head (d4a4f83).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13608    13618   +10     
  Branches     3610     3617    +7     
=======================================
+ Hits        13386    13396   +10     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/SidebarLayout/SidebarLayout.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/SettingsTab/SettingsTab.tsx 100.00% <100.00%> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.18% <100.00%> (+<0.01%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980d71...d4a4f83. Read the comment docs.

Copy link

codecov bot commented Jul 19, 2024

Bundle Report

Changes will increase total bundle size by 533 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.86MB 533 bytes ⬆️

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (d980d71) to head (d4a4f83).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3040   +/-   ##
===========================================
  Coverage   98.36000   98.36000           
===========================================
  Files           914        914           
  Lines         13608      13618   +10     
  Branches       3610       3617    +7     
===========================================
+ Hits          13386      13396   +10     
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
src/layouts/SidebarLayout/SidebarLayout.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/SettingsTab/SettingsTab.tsx 100.00% <100.00%> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.18% <100.00%> (+<0.01%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980d71...d4a4f83. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (d980d71) to head (d4a4f83).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3040   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13608    13618   +10     
  Branches     3687     3617   -70     
=======================================
+ Hits        13386    13396   +10     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/SidebarLayout/SidebarLayout.jsx 100.00% <100.00%> (ø)
src/pages/RepoPage/SettingsTab/SettingsTab.tsx 100.00% <100.00%> (ø)
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (ø)
src/services/navigation/useNavLinks/useNavLinks.js 99.18% <100.00%> (+<0.01%) ⬆️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (ø)
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980d71...d4a4f83. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d4a4f83 Fri, 19 Jul 2024 19:27:49 GMT Cloud Enterprise

Comment on lines +40 to +42
expect(
await screen.findByRole('link', { name: /General/ })
).toBeInTheDocument()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna ask for any changes, but moving forward can we pull these *By* out into their own vars and than use the vars in the expects

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit e4e591c Jul 22, 2024
60 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/add-configuration-manager-tab branch July 22, 2024 13:09
Copy link

sentry-io bot commented Jul 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: ["YamlConfig","[gh","gl","\n query YamlConfig($username: String!){\n owner(username: $use... /account/:provider/:owner/yaml/ View Issue
  • ‼️ Error: ["YamlConfig","[gh","gl","\n query YamlConfig($username: String!){\n owner(username: $use... /account/:provider/:owner/yaml/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Configuration Manager tab in repo settings locked behind feature flag
3 participants