Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Hide self-hosted header items on small screen sizes #3037

Merged
merged 1 commit into from
Jul 19, 2024
Merged

style: Hide self-hosted header items on small screen sizes #3037

merged 1 commit into from
Jul 19, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Hides the self-hosted header items on small screen sizes as they clutter things up and make weird layouts occur.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 18, 2024 20:47
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-responsiveness-tweak branch from d71da7e to 1cb2421 Compare July 18, 2024 20:47
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 87 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.86MB 87 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (db3656e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13604           
  Branches     3679     3607   -72     
=======================================
  Hits        13382    13382           
  Misses        218      218           
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (ø)
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...db3656e. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024

Bundle Report

Changes will increase total bundle size by 87 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.86MB 87 bytes ⬆️

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (db3656e).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13604           
  Branches     3679     3657   -22     
=======================================
  Hits        13382    13382           
  Misses        218      218           
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (ø)
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...db3656e. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13604           
  Branches     3684     3607   -77     
=======================================
  Hits        13382    13382           
  Misses        218      218           
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (ø)
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...db3656e. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (db3656e).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3037   +/-   ##
===========================================
  Coverage   98.36000   98.36000           
===========================================
  Files           914        914           
  Lines         13604      13604           
  Branches       3679       3607   -72     
===========================================
  Hits          13382      13382           
  Misses          218        218           
  Partials          4          4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (ø)
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...db3656e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 18, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1cb2421 Thu, 18 Jul 2024 20:54:16 GMT Expired Expired
1cb2421 Thu, 18 Jul 2024 20:55:48 GMT Expired Expired
db3656e Fri, 19 Jul 2024 14:06:21 GMT Cloud Enterprise

ajay-sentry
ajay-sentry approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-responsiveness-tweak branch from 1cb2421 to db3656e Compare July 19, 2024 13:24
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 5a77fbd Jul 19, 2024
60 of 61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/new-header-responsiveness-tweak branch July 19, 2024 14:38
suejung-sentry pushed a commit that referenced this pull request Jul 19, 2024
@spalmurray-codecov @suejung-sentry
style: Hide self-hosted header items on small screen sizes (#3037)
9eb81e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray-codecov @codecov-releaser @ajay-sentry