Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Help dropdown user feedback scrolling bug #3022

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Fixes bug where the Sentry feedback modal would disable scrolling on the page and not reenable it on close. Also updates Sentry sdk to latest version (not necessary for fix).

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 16, 2024 19:11
Copy link

codecov-public-qa bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (0f04370) to head (b5149bd).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         910      910              
  Lines       13535    13534       -1     
  Branches     3664     3588      -76     
==========================================
- Hits        13313    13312       -1     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.67% <100.00%> (-0.01%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f04370...b5149bd. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         910      910              
  Lines       13535    13534       -1     
  Branches     3638     3659      +21     
==========================================
- Hits        13313    13312       -1     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.67% <100.00%> (-0.01%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f04370...b5149bd. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (0f04370) to head (b5149bd).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         910      910              
  Lines       13535    13534       -1     
  Branches     3588     3659      +71     
==========================================
- Hits        13313    13312       -1     
  Misses        218      218              
  Partials        4        4              
Files Coverage Δ
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.67% <100.00%> (-0.01%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f04370...b5149bd. Read the comment docs.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (0f04370) to head (b5149bd).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3022   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           910        910           
  Lines         13535      13534    -1     
  Branches       3659       3638   -21     
===========================================
- Hits          13313      13312    -1     
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.67% <100.00%> (-0.01%) ⬇️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f04370...b5149bd. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 16, 2024

Bundle Report

Changes will increase total bundle size by 7.11kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.08MB 7.11kB ⬆️

Copy link

codecov bot commented Jul 16, 2024

Bundle Report

Changes will increase total bundle size by 7.11kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.08MB 7.11kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 16, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
9d018b9 Tue, 16 Jul 2024 19:23:09 GMT Expired Expired
9d018b9 Tue, 16 Jul 2024 19:34:20 GMT Expired Expired
b5149bd Wed, 17 Jul 2024 14:55:51 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/fix-sentry-feedback-bug branch from 9d018b9 to b5149bd Compare July 17, 2024 14:43
@nicholas-codecov nicholas-codecov self-requested a review July 17, 2024 14:58
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 0756143 Jul 17, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-sentry-feedback-bug branch July 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants