-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Help dropdown user feedback scrolling bug #3022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 910 910
Lines 13535 13534 -1
Branches 3664 3588 -76
==========================================
- Hits 13313 13312 -1
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 910 910
Lines 13535 13534 -1
Branches 3638 3659 +21
==========================================
- Hits 13313 13312 -1
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 98.35% 98.35% -0.01%
==========================================
Files 910 910
Lines 13535 13534 -1
Branches 3588 3659 +71
==========================================
- Hits 13313 13312 -1
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
===========================================
Coverage 98.35000 98.35000
===========================================
Files 910 910
Lines 13535 13534 -1
Branches 3659 3638 -21
===========================================
- Hits 13313 13312 -1
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 7.11kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 7.11kB ⬆️
|
9d018b9
to
b5149bd
Compare
Fixes bug where the Sentry feedback modal would disable scrolling on the page and not reenable it on close. Also updates Sentry sdk to latest version (not necessary for fix).