Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move render error down the download link in upload card. #3018

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Jul 16, 2024

Description

Fixing text wrap + place of error in upload card.

Screenshots

Screenshot 2024-07-16 at 1 44 17 PM Screenshot 2024-07-16 at 1 44 06 PM

issue: codecov/engineering-team#2085

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (1ecc77f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      907           
  Lines       13476    13476           
  Branches     3559     3607   +48     
=======================================
  Hits        13254    13254           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <ø> (ø)
...itDetailPage/CommitCoverage/UploadsCard/Upload.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.54% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...1ecc77f. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (1ecc77f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      907           
  Lines       13476    13476           
  Branches     3607     3559   -48     
=======================================
  Hits        13254    13254           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <ø> (ø)
...itDetailPage/CommitCoverage/UploadsCard/Upload.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.54% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...1ecc77f. Read the comment docs.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (135fdf5) to head (1ecc77f).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3018   +/-   ##
===========================================
  Coverage   98.35000   98.35000           
===========================================
  Files           907        907           
  Lines         13476      13476           
  Branches       3633       3559   -74     
===========================================
  Hits          13254      13254           
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <ø> (ø)
...itDetailPage/CommitCoverage/UploadsCard/Upload.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.54% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...1ecc77f. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         907      907           
  Lines       13476    13476           
  Branches     3633     3559   -74     
=======================================
  Hits        13254    13254           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...ailPage/CommitCoverage/UploadsCard/RenderError.tsx 100.00% <ø> (ø)
...itDetailPage/CommitCoverage/UploadsCard/Upload.jsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.54% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135fdf5...1ecc77f. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 16, 2024

Bundle Report

Changes will increase total bundle size by 44 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.1MB 44 bytes ⬆️

Copy link

codecov bot commented Jul 16, 2024

Bundle Report

Changes will increase total bundle size by 44 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.1MB 44 bytes ⬆️

@RulaKhaled RulaKhaled marked this pull request as ready for review July 16, 2024 11:45
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 16, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1ecc77f Tue, 16 Jul 2024 11:48:16 GMT Expired Expired
1ecc77f Tue, 16 Jul 2024 11:55:35 GMT Cloud Enterprise

@RulaKhaled RulaKhaled added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit c27a338 Jul 16, 2024
61 checks passed
@RulaKhaled RulaKhaled deleted the fix-download-link-place branch July 16, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants