-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move render error down the download link in upload card. #3018
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3018 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13476 13476
Branches 3559 3607 +48
=======================================
Hits 13254 13254
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3018 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13476 13476
Branches 3607 3559 -48
=======================================
Hits 13254 13254
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
===========================================
Coverage 98.35000 98.35000
===========================================
Files 907 907
Lines 13476 13476
Branches 3633 3559 -74
===========================================
Hits 13254 13254
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3018 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13476 13476
Branches 3633 3559 -74
=======================================
Hits 13254 13254
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 44 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 44 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
Fixing text wrap + place of error in upload card.
Screenshots
issue: codecov/engineering-team#2085
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.