feat: Add Update Plan blurb when changing plan details #3008
Conversation
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.tsx
Show resolved
Hide resolved
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpgradeForm.tsx
Show resolved
Hide resolved
Bundle ReportChanges will increase total bundle size by 1.36kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 1.36kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3008 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 907 908 +1
Lines 13454 13485 +31
Branches 3579 3550 -29
=======================================
+ Hits 13232 13263 +31
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3008 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 907 908 +1
Lines 13454 13485 +31
Branches 3531 3550 +19
=======================================
+ Hits 13232 13263 +31
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3008 +/- ##
=======================================
Coverage 98.34% 98.35%
=======================================
Files 907 908 +1
Lines 13454 13485 +31
Branches 3579 3598 +19
=======================================
+ Hits 13232 13263 +31
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3008 +/- ##
================================================
+ Coverage 98.34000 98.35000 +0.01000
================================================
Files 907 908 +1
Lines 13454 13485 +31
Branches 3604 3598 -6
================================================
+ Hits 13232 13263 +31
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Description
This PR aims to add a blurb at the bottom of the manage plan page to better inform users of the plan changes they are making and when they will take effect.
When the user is "upgrading" their plan, the change takes effect immediately; when they increase the number of seats, go from team -> pro, or from monthly -> annual. This matches the logic in API here: https://github.com/codecov/codecov-api/blob/638aeca732ec08e901f4f7443fb35b799b181843/services/billing.py#L350-L358
When the user "downgrades" (non-upgrade), the plan change takes effect at the start of the following billing cycle.
figma
Closes codecov/engineering-team#1853
Notable Changes
I decided to create a new component for these changes just to isolate them, and if we ever want to use this blurb somewhere else we totally can. I also chose to create a ton of consts at the top of the component before doing all the styling just because I thought that was a little easier to decipher through.
Lots of logic happening to happy to answer questions about it! Otherwise here's a video below in action
Screenshots
Screen.Recording.2024-07-11.at.3.23.13.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.