feat: add back and cancel btns to TOS and Org select pages #3007
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3007 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13486 13486
Branches 3626 3631 +5
=======================================
Hits 13264 13264
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3007 +/- ##
===========================================
Coverage 98.35000 98.35000
===========================================
Files 907 907
Lines 13486 13486
Branches 3557 3557
===========================================
Hits 13264 13264
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 259 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 259 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3007 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13486 13486
Branches 3626 3605 -21
=======================================
Hits 13264 13264
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3007 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 907 907
Lines 13486 13486
Branches 3557 3557
=======================================
Hits 13264 13264
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| <Button hook="user selects org, continues to app" type="submit"> | ||
| Continue | ||
| Continue to app |
There was a problem hiding this comment.
l: 'app' seems like a strange word to use. 'Continue to Codecov' better IMO.
calvin-codecov
force-pushed
the
user_onboard_back_cancel_btns
branch
from
adbde38 to
8116646
Compare
Description
Closes codecov/engineering-team#1940
Added a story for Listbox variant of the Button as it seems like it was missed.
I believe keeping copy text as "Which organization" is more grammatically correct for org selector as we have a list.
Figma: bottom of https://www.figma.com/design/kbJfmcDgAuptsJR5KB28O9/GH-293-(nav%2C-header%2C-and-related-elements)?node-id=322-1385&t=rNtuPGrNv5Adbn8H-1
Code Example
Notable Changes
Screenshots
Screen.Recording.2024-07-11.at.3.48.29.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.