Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Oldheader admin link has wrong link variant #3001

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

Fixes wrong variant added by accident.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 10, 2024 18:18
@eliatcodecov
Copy link
Contributor

@codecov-ai-reviewer I've renamed the bot. Let's see if it'll still review. As usual, you can ignore anything it says for now.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (cc9b867) to head (67ceada).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         906      906           
  Lines       13392    13392           
  Branches     3507     3573   +66     
=======================================
  Hits        13170    13170           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <ø> (ø)
src/layouts/OldHeader/AdminLink.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.56% <ø> (ø)
Pages 99.14% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9b867...67ceada. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         906      906           
  Lines       13392    13392           
  Branches     3553     3507   -46     
=======================================
  Hits        13170    13170           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <ø> (ø)
src/layouts/OldHeader/AdminLink.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.56% <ø> (ø)
Pages 99.14% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9b867...67ceada. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 7 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.09MB 7 bytes ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (cc9b867) to head (67ceada).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         906      906           
  Lines       13392    13392           
  Branches     3553     3553           
=======================================
  Hits        13170    13170           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <ø> (ø)
src/layouts/OldHeader/AdminLink.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.56% <ø> (ø)
Pages 99.14% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9b867...67ceada. Read the comment docs.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (cc9b867) to head (67ceada).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3001   +/-   ##
===========================================
  Coverage   98.34000   98.34000           
===========================================
  Files           906        906           
  Lines         13392      13392           
  Branches       3573       3578    +5     
===========================================
  Hits          13170      13170           
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
.../layouts/Header/components/AdminLink/AdminLink.tsx 100.00% <ø> (ø)
src/layouts/OldHeader/AdminLink.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.56% <ø> (ø)
Pages 99.14% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9b867...67ceada. Read the comment docs.

Copy link

codecov bot commented Jul 10, 2024

Bundle Report

Changes will increase total bundle size by 7 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.09MB 7 bytes ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
67ceada Wed, 10 Jul 2024 18:28:08 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit c317d98 Jul 10, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/fix-admin-link-variant branch July 10, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants