Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make after nullable for BA queries #2995

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Aligning these queries with updates to the API.

@nicholas-codecov nicholas-codecov changed the title chore: Make after non nullable for BA queries chore: Make after nullable for BA queries Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Bundle Report

Changes will decrease total bundle size by 2 bytes ⬇️

Bundle name Size Change
gazebo-production-array-push 6.78MB 2 bytes ⬇️

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 2 bytes ⬇️

Bundle name Size Change
gazebo-staging-array-push 6.78MB 2 bytes ⬇️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d9942e9 Tue, 09 Jul 2024 14:26:06 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (bfe41cb) to head (d9942e9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13318           
  Branches     3533     3558   +25     
=======================================
  Hits        13096    13096           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 100.00% <ø> (ø)
src/services/bundleAnalysis/useBundleTrendData.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe41cb...d9942e9. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (bfe41cb) to head (d9942e9).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13318           
  Branches     3553     3487   -66     
=======================================
  Hits        13096    13096           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 100.00% <ø> (ø)
src/services/bundleAnalysis/useBundleTrendData.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe41cb...d9942e9. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13318           
  Branches     3533     3553   +20     
=======================================
  Hits        13096    13096           
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 100.00% <ø> (ø)
src/services/bundleAnalysis/useBundleTrendData.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe41cb...d9942e9. Read the comment docs.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (bfe41cb) to head (d9942e9).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2995   +/-   ##
===========================================
  Coverage   98.33000   98.33000           
===========================================
  Files           902        902           
  Lines         13318      13318           
  Branches       3558       3487   -71     
===========================================
  Hits          13096      13096           
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
src/services/bundleAnalysis/useBundleAssets.tsx 100.00% <ø> (ø)
src/services/bundleAnalysis/useBundleTrendData.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe41cb...d9942e9. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit c8dee68 Jul 9, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-make-after-non-nullable branch July 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants