Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap successful plan change msg to banner #2992

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

calvin-codecov
Copy link
Contributor

Description

Closes codecov/engineering-team#1817
Point 1 of https://www.figma.com/design/jUKX9i3Lcgq7VE0zpwUxXM/GH-1508?node-id=1-464&t=nEkyUWPxZMtQCdO4-1

Code Example

Notable Changes

Screenshots

Increase in seats
Screenshot 2024-07-08 at 10 59 25 PM
Scheduled change with decrease in seats
Screenshot 2024-07-08 at 10 59 39 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (0a326dc) to head (60836c8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   98.33%   98.34%   +0.01%     
==========================================
  Files         907      907              
  Lines       13429    13454      +25     
  Branches     3589     3604      +15     
==========================================
+ Hits        13205    13232      +27     
+ Misses        219      218       -1     
+ Partials        5        4       -1     
Files Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <ø> (ø)
src/pages/PlanPage/context.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (+13.33%) ⬆️
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.js 100.00% <100.00%> (ø)
...plan/ScheduledPlanDetails/ScheduledPlanDetails.jsx 100.00% <100.00%> (ø)
src/ui/Alert/Alert.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.60% <ø> (ø)
Pages 99.15% <100.00%> (+0.03%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (ø)
UI 94.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a326dc...60836c8. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   98.33%   98.34%   +0.01%     
==========================================
  Files         907      907              
  Lines       13429    13454      +25     
  Branches     3522     3531       +9     
==========================================
+ Hits        13205    13232      +27     
+ Misses        219      218       -1     
+ Partials        5        4       -1     
Files Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <ø> (ø)
src/pages/PlanPage/context.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (+13.33%) ⬆️
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.js 100.00% <100.00%> (ø)
...plan/ScheduledPlanDetails/ScheduledPlanDetails.jsx 100.00% <100.00%> (ø)
src/ui/Alert/Alert.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.60% <ø> (ø)
Pages 99.15% <100.00%> (+0.03%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (ø)
UI 94.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a326dc...60836c8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (0a326dc) to head (60836c8).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   98.33%   98.34%   +0.01%     
==========================================
  Files         907      907              
  Lines       13429    13454      +25     
  Branches     3589     3531      -58     
==========================================
+ Hits        13205    13232      +27     
+ Misses        219      218       -1     
+ Partials        5        4       -1     
Files Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <ø> (ø)
src/pages/PlanPage/context.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (+13.33%) ⬆️
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.js 100.00% <100.00%> (ø)
...plan/ScheduledPlanDetails/ScheduledPlanDetails.jsx 100.00% <100.00%> (ø)
src/ui/Alert/Alert.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.60% <ø> (ø)
Pages 99.15% <100.00%> (+0.03%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (ø)
UI 94.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a326dc...60836c8. Read the comment docs.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (0a326dc) to head (60836c8).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #2992        +/-   ##
================================================
+ Coverage   98.33000   98.34000   +0.01000     
================================================
  Files           907        907                
  Lines         13429      13454        +25     
  Branches       3522       3599        +77     
================================================
+ Hits          13205      13232        +27     
+ Misses          219        218         -1     
+ Partials          5          4         -1     
Files Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <ø> (ø)
src/pages/PlanPage/context.tsx 100.00% <100.00%> (ø)
...anPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.tsx 100.00% <100.00%> (+13.33%) ⬆️
...dePlanPage/UpgradeForm/hooks/useUpgradeControls.js 100.00% <100.00%> (ø)
...plan/ScheduledPlanDetails/ScheduledPlanDetails.jsx 100.00% <100.00%> (ø)
src/ui/Alert/Alert.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.60% <ø> (ø)
Pages 99.15% <100.00%> (+0.03%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <100.00%> (ø)
UI 94.27% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a326dc...60836c8. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 9, 2024

Bundle Report

Changes will increase total bundle size by 4.74kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.09MB 4.74kB ⬆️

Copy link

codecov bot commented Jul 9, 2024

Bundle Report

Changes will increase total bundle size by 4.74kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.09MB 4.74kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 9, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
58456f8 Tue, 09 Jul 2024 06:16:55 GMT Expired Expired
58456f8 Tue, 09 Jul 2024 06:20:22 GMT Expired Expired
297edd1 Wed, 10 Jul 2024 17:01:39 GMT Expired Expired
9ccd887 Wed, 10 Jul 2024 20:52:40 GMT Expired Expired
cc1ecc2 Wed, 10 Jul 2024 21:21:26 GMT Expired Expired
4fa3bb4 Wed, 10 Jul 2024 22:10:10 GMT Expired Expired
6002594 Thu, 11 Jul 2024 00:38:59 GMT Expired Expired
d8491ef Thu, 11 Jul 2024 17:07:46 GMT Expired Expired
60836c8 Thu, 11 Jul 2024 18:34:48 GMT Cloud Enterprise

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments to peak at

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good! Send it

@calvin-codecov calvin-codecov enabled auto-merge July 11, 2024 16:56
@calvin-codecov calvin-codecov added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@calvin-codecov calvin-codecov added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 263f99d Jul 11, 2024
61 checks passed
@calvin-codecov calvin-codecov deleted the plan_upgraded_banner branch July 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "plan successfully upgraded" message -> "plan successfully upgraded" banner component
4 participants