-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swap successful plan change msg to banner #2992
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 98.33% 98.34% +0.01%
==========================================
Files 907 907
Lines 13429 13454 +25
Branches 3589 3604 +15
==========================================
+ Hits 13205 13232 +27
+ Misses 219 218 -1
+ Partials 5 4 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 98.33% 98.34% +0.01%
==========================================
Files 907 907
Lines 13429 13454 +25
Branches 3522 3531 +9
==========================================
+ Hits 13205 13232 +27
+ Misses 219 218 -1
+ Partials 5 4 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 98.33% 98.34% +0.01%
==========================================
Files 907 907
Lines 13429 13454 +25
Branches 3589 3531 -58
==========================================
+ Hits 13205 13232 +27
+ Misses 219 218 -1
+ Partials 5 4 -1
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
================================================
+ Coverage 98.33000 98.34000 +0.01000
================================================
Files 907 907
Lines 13429 13454 +25
Branches 3522 3599 +77
================================================
+ Hits 13205 13232 +27
+ Misses 219 218 -1
+ Partials 5 4 -1
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 4.74kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 4.74kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments to peak at
58456f8
to
297edd1
Compare
cc1ecc2
to
4fa3bb4
Compare
src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.spec.tsx
Outdated
Show resolved
Hide resolved
src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.spec.tsx
Outdated
Show resolved
Hide resolved
src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookin good! Send it
Description
Closes codecov/engineering-team#1817
Point 1 of https://www.figma.com/design/jUKX9i3Lcgq7VE0zpwUxXM/GH-1508?node-id=1-464&t=nEkyUWPxZMtQCdO4-1
Code Example
Notable Changes
Screenshots
Increase in seats
Scheduled change with decrease in seats
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.